LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Jeff Garzik <jgarzik@pobox.com>
To: Alan <alan@lxorguk.ukuu.org.uk>
Cc: andersen@codepoet.org, linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] make sata_promise PATA ports work
Date: Mon, 04 Dec 2006 18:22:56 -0500	[thread overview]
Message-ID: <4574ADD0.4060803@pobox.com> (raw)
In-Reply-To: <20061204201601.06933372@localhost.localdomain>

Alan wrote:
> On Mon, 4 Dec 2006 12:47:37 -0700
> Erik Andersen <andersen@codepoet.org> wrote:
> 
>> This patch vs 2.6.19, based on the not-actually-working-for-me
>> code lurking in libata-dev.git#promise-sata-pata, makes the PATA
>> ports on my promise sata card actually work.  Since the plan as
> 
> Nice, this is pretty much what is needed to polish up the other split
> PATA/SATA cases.

Disagree.  Internal libata is set up so that you can have different 
ata_port::flags and ata_port::ops for each port, which is what enables 
proper hardware sharing between SATA and PATA.

Two things need to happen:

1) probe_ent needs to permit a driver to supply multiple flags/ops 
pairs, not just one for the whole driver, and pass that through to the 
proper data structures during ata_port init.

2) a VERY FEW details like ->irq_clear() are really ata_host level 
hooks, but they live in ata_port_operations because there is no 
ata_host_operations.  Fix these.

Once those issues are fixed, PATA+SATA can be easily support on the 
combinations of hardware that have been desperately wanting it: 
sata_promise, sata_sis, sata_via (sata_uli too?)

	Jeff




  reply	other threads:[~2006-12-04 23:23 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-12-04 19:47 Erik Andersen
2006-12-04 20:16 ` Alan
2006-12-04 23:22   ` Jeff Garzik [this message]
2006-12-06 18:12 Mikael Pettersson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4574ADD0.4060803@pobox.com \
    --to=jgarzik@pobox.com \
    --cc=alan@lxorguk.ukuu.org.uk \
    --cc=andersen@codepoet.org \
    --cc=linux-kernel@vger.kernel.org \
    --subject='Re: [PATCH] make sata_promise PATA ports work' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).