LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* sparse errors in srcu.h
@ 2006-12-06 9:50 Brice Goglin
2006-12-06 16:15 ` Paul E. McKenney
0 siblings, 1 reply; 5+ messages in thread
From: Brice Goglin @ 2006-12-06 9:50 UTC (permalink / raw)
To: Paul E. McKenney; +Cc: LKML
Hi,
When running sparse checks on a file that ends up including srcu.h, we
get the following warnings:
include/linux/srcu.h:52:44: error: undefined identifier 'sp'
include/linux/srcu.h:52:44: error: bad constant expression
include/linux/srcu.h:53:56: error: undefined identifier 'sp'
include/linux/srcu.h:53:56: error: bad constant expression
It seems to be caused by the following lines:
int srcu_read_lock(struct srcu_struct *sp) __acquires(sp);
void srcu_read_unlock(struct srcu_struct *sp, int idx) __releases(sp);
which come from the following commit.
commit 621934ee7ed5b073c7fd638b347e632c53572761
Author: Paul E. McKenney <paulmck@us.ibm.com>
Date: Wed Oct 4 02:17:02 2006 -0700
[PATCH] srcu-3: RCU variant permitting read-side blocking
I was wondering if there is a way to fix those errors...
Thanks,
Brice
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: sparse errors in srcu.h
2006-12-06 9:50 sparse errors in srcu.h Brice Goglin
@ 2006-12-06 16:15 ` Paul E. McKenney
2006-12-07 9:26 ` Brice Goglin
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Paul E. McKenney @ 2006-12-06 16:15 UTC (permalink / raw)
To: Brice Goglin; +Cc: Paul E. McKenney, LKML
On Wed, Dec 06, 2006 at 10:50:14AM +0100, Brice Goglin wrote:
> Hi,
>
> When running sparse checks on a file that ends up including srcu.h, we
> get the following warnings:
>
> include/linux/srcu.h:52:44: error: undefined identifier 'sp'
> include/linux/srcu.h:52:44: error: bad constant expression
> include/linux/srcu.h:53:56: error: undefined identifier 'sp'
> include/linux/srcu.h:53:56: error: bad constant expression
>
> It seems to be caused by the following lines:
>
> int srcu_read_lock(struct srcu_struct *sp) __acquires(sp);
> void srcu_read_unlock(struct srcu_struct *sp, int idx) __releases(sp);
>
> which come from the following commit.
>
> commit 621934ee7ed5b073c7fd638b347e632c53572761
> Author: Paul E. McKenney <paulmck@us.ibm.com>
> Date: Wed Oct 4 02:17:02 2006 -0700
>
> [PATCH] srcu-3: RCU variant permitting read-side blocking
>
>
> I was wondering if there is a way to fix those errors...
I believe that you need to update your version of sparse to 0.1.
See http://lwn.net/Articles/208312/ for more info.
Thanx, Paul
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: sparse errors in srcu.h
2006-12-06 16:15 ` Paul E. McKenney
@ 2006-12-07 9:26 ` Brice Goglin
2006-12-07 9:32 ` Brice Goglin
2006-12-07 9:34 ` Brice Goglin
2 siblings, 0 replies; 5+ messages in thread
From: Brice Goglin @ 2006-12-07 9:26 UTC (permalink / raw)
To: paulmck; +Cc: Paul E. McKenney, LKML
Paul E. McKenney wrote:
> On Wed, Dec 06, 2006 at 10:50:14AM +0100, Brice Goglin wrote:
>
>> Hi,
>>
>> When running sparse checks on a file that ends up including srcu.h, we
>> get the following warnings:
>>
>> include/linux/srcu.h:52:44: error: undefined identifier 'sp'
>> include/linux/srcu.h:52:44: error: bad constant expression
>> include/linux/srcu.h:53:56: error: undefined identifier 'sp'
>> include/linux/srcu.h:53:56: error: bad constant expression
>>
>> It seems to be caused by the following lines:
>>
>> int srcu_read_lock(struct srcu_struct *sp) __acquires(sp);
>> void srcu_read_unlock(struct srcu_struct *sp, int idx) __releases(sp);
>>
>> which come from the following commit.
>>
>> commit 621934ee7ed5b073c7fd638b347e632c53572761
>> Author: Paul E. McKenney <paulmck@us.ibm.com>
>> Date: Wed Oct 4 02:17:02 2006 -0700
>>
>> [PATCH] srcu-3: RCU variant permitting read-side blocking
>>
>>
>> I was wondering if there is a way to fix those errors...
>>
>
> I believe that you need to update your version of sparse to 0.1.
> See http://lwn.net/Articles/208312/ for more info.
>
> Thanx, Paul
>
Right, thanks, I had an old version hidden in /usr/local, works fine now.
Brice
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: sparse errors in srcu.h
2006-12-06 16:15 ` Paul E. McKenney
2006-12-07 9:26 ` Brice Goglin
@ 2006-12-07 9:32 ` Brice Goglin
2006-12-07 9:34 ` Brice Goglin
2 siblings, 0 replies; 5+ messages in thread
From: Brice Goglin @ 2006-12-07 9:32 UTC (permalink / raw)
To: paulmck; +Cc: Paul E. McKenney, LKML
Paul E. McKenney wrote:
> On Wed, Dec 06, 2006 at 10:50:14AM +0100, Brice Goglin wrote:
>
>> Hi,
>>
>> When running sparse checks on a file that ends up including srcu.h, we
>> get the following warnings:
>>
>> include/linux/srcu.h:52:44: error: undefined identifier 'sp'
>> include/linux/srcu.h:52:44: error: bad constant expression
>> include/linux/srcu.h:53:56: error: undefined identifier 'sp'
>> include/linux/srcu.h:53:56: error: bad constant expression
>>
>> It seems to be caused by the following lines:
>>
>> int srcu_read_lock(struct srcu_struct *sp) __acquires(sp);
>> void srcu_read_unlock(struct srcu_struct *sp, int idx) __releases(sp);
>>
>> which come from the following commit.
>>
>> commit 621934ee7ed5b073c7fd638b347e632c53572761
>> Author: Paul E. McKenney <paulmck@us.ibm.com>
>> Date: Wed Oct 4 02:17:02 2006 -0700
>>
>> [PATCH] srcu-3: RCU variant permitting read-side blocking
>>
>>
>> I was wondering if there is a way to fix those errors...
>>
>
> I believe that you need to update your version of sparse to 0.1.
> See http://lwn.net/Articles/208312/ for more info.
>
> Thanx, Paul
>
Right, thanks, I had an old version hidden in /usr/local, works fine now.
Brice
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: sparse errors in srcu.h
2006-12-06 16:15 ` Paul E. McKenney
2006-12-07 9:26 ` Brice Goglin
2006-12-07 9:32 ` Brice Goglin
@ 2006-12-07 9:34 ` Brice Goglin
2 siblings, 0 replies; 5+ messages in thread
From: Brice Goglin @ 2006-12-07 9:34 UTC (permalink / raw)
To: paulmck; +Cc: Paul E. McKenney, LKML
Paul E. McKenney wrote:
> On Wed, Dec 06, 2006 at 10:50:14AM +0100, Brice Goglin wrote:
>
>> Hi,
>>
>> When running sparse checks on a file that ends up including srcu.h, we
>> get the following warnings:
>>
>> include/linux/srcu.h:52:44: error: undefined identifier 'sp'
>> include/linux/srcu.h:52:44: error: bad constant expression
>> include/linux/srcu.h:53:56: error: undefined identifier 'sp'
>> include/linux/srcu.h:53:56: error: bad constant expression
>>
>> It seems to be caused by the following lines:
>>
>> int srcu_read_lock(struct srcu_struct *sp) __acquires(sp);
>> void srcu_read_unlock(struct srcu_struct *sp, int idx) __releases(sp);
>>
>> which come from the following commit.
>>
>> commit 621934ee7ed5b073c7fd638b347e632c53572761
>> Author: Paul E. McKenney <paulmck@us.ibm.com>
>> Date: Wed Oct 4 02:17:02 2006 -0700
>>
>> [PATCH] srcu-3: RCU variant permitting read-side blocking
>>
>>
>> I was wondering if there is a way to fix those errors...
>>
>
> I believe that you need to update your version of sparse to 0.1.
> See http://lwn.net/Articles/208312/ for more info.
>
> Thanx, Paul
>
Right, thanks, I had an old version hidden in /usr/local, works fine now.
Brice
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2006-12-07 10:04 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2006-12-06 9:50 sparse errors in srcu.h Brice Goglin
2006-12-06 16:15 ` Paul E. McKenney
2006-12-07 9:26 ` Brice Goglin
2006-12-07 9:32 ` Brice Goglin
2006-12-07 9:34 ` Brice Goglin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).