LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [BUG][PATCH] pcieport-driver: remove invalid warning message
@ 2006-12-06 13:07 Kenji Kaneshige
  0 siblings, 0 replies; only message in thread
From: Kenji Kaneshige @ 2006-12-06 13:07 UTC (permalink / raw)
  To: Greg KH, tom.l.nguyen; +Cc: linux-pci, linux-kernel

Hi,

I got the following warning messages on some PCI Express ports.

    pcie_portdrv_probe->Dev[1263:10cf] has invalid IRQ. Check vendor BIOS

I think this message is improper because those PCI Express ports don't
use an interrupt pin. This message should not be displayed for devices
which don't use an interrupt pin.

Thanks,
Kenji Kaneshige


The following warning message should not be displayed for devices
which don't use an interrupt pin.

    pcie_portdrv_probe->Dev[XXXX:XXXX] has invalid IRQ. Check vendor BIOS

Signed-off-by: Kenji Kaneshige <kaneshige.kenji@jp.fujitsu.com>

---
 drivers/pci/pcie/portdrv_pci.c |    2 +-
 1 files changed, 1 insertion(+), 1 deletion(-)

Index: linux-2.6.19/drivers/pci/pcie/portdrv_pci.c
===================================================================
--- linux-2.6.19.orig/drivers/pci/pcie/portdrv_pci.c	2006-12-06 21:31:32.000000000 +0900
+++ linux-2.6.19/drivers/pci/pcie/portdrv_pci.c	2006-12-06 21:31:38.000000000 +0900
@@ -90,7 +90,7 @@
 		return -ENODEV;
 	
 	pci_set_master(dev);
-        if (!dev->irq) {
+        if (!dev->irq && dev->pin) {
 		printk(KERN_WARNING 
 		"%s->Dev[%04x:%04x] has invalid IRQ. Check vendor BIOS\n", 
 		__FUNCTION__, dev->device, dev->vendor);



^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2006-12-06 13:13 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2006-12-06 13:07 [BUG][PATCH] pcieport-driver: remove invalid warning message Kenji Kaneshige

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).