LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Brice Goglin <Brice.Goglin@ens-lyon.org>
To: paulmck@linux.vnet.ibm.com
Cc: "Paul E. McKenney" <paulmck@us.ibm.com>,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: sparse errors in srcu.h
Date: Thu, 07 Dec 2006 10:26:30 +0100	[thread overview]
Message-ID: <4577DE46.5000603@ens-lyon.org> (raw)
In-Reply-To: <20061206161537.GA2013@linux.vnet.ibm.com>

Paul E. McKenney wrote:
> On Wed, Dec 06, 2006 at 10:50:14AM +0100, Brice Goglin wrote:
>   
>> Hi,
>>
>> When running sparse checks on a file that ends up including srcu.h, we
>> get the following warnings:
>>
>>     include/linux/srcu.h:52:44: error: undefined identifier 'sp'
>>     include/linux/srcu.h:52:44: error: bad constant expression
>>     include/linux/srcu.h:53:56: error: undefined identifier 'sp'
>>     include/linux/srcu.h:53:56: error: bad constant expression
>>
>> It seems to be caused by the following lines:
>>
>>     int srcu_read_lock(struct srcu_struct *sp) __acquires(sp);
>>     void srcu_read_unlock(struct srcu_struct *sp, int idx) __releases(sp);
>>
>> which come from the following commit.
>>
>>     commit 621934ee7ed5b073c7fd638b347e632c53572761
>>     Author: Paul E. McKenney <paulmck@us.ibm.com>
>>     Date:   Wed Oct 4 02:17:02 2006 -0700
>>
>>     [PATCH] srcu-3: RCU variant permitting read-side blocking
>>
>>
>> I was wondering if there is a way to fix those errors...
>>     
>
> I believe that you need to update your version of sparse to 0.1.
> See http://lwn.net/Articles/208312/ for more info.
>
> 							Thanx, Paul
>   

Right, thanks, I had an old version hidden in /usr/local, works fine now.

Brice


  reply	other threads:[~2006-12-07  9:26 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-12-06  9:50 Brice Goglin
2006-12-06 16:15 ` Paul E. McKenney
2006-12-07  9:26   ` Brice Goglin [this message]
2006-12-07  9:32   ` Brice Goglin
2006-12-07  9:34   ` Brice Goglin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4577DE46.5000603@ens-lyon.org \
    --to=brice.goglin@ens-lyon.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=paulmck@linux.vnet.ibm.com \
    --cc=paulmck@us.ibm.com \
    --subject='Re: sparse errors in srcu.h' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).