LKML Archive on lore.kernel.org
 help / color / Atom feed
From: Rene Herman <rene.herman@gmail.com>
To: Rolf Eike Beer <eike-kernel@sf-tec.de>
Cc: "Ahmed S. Darwish" <darwish.07@gmail.com>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH UPDATED 2.6.20-rc3] Remove all the unneeded k[mzc]alloc casts
Date: Mon, 08 Jan 2007 14:54:34 +0100
Message-ID: <45A24D1A.7020004@gmail.com> (raw)
In-Reply-To: <200701081310.46547.eike-kernel@sf-tec.de>

On 01/08/2007 01:10 PM, Rolf Eike Beer wrote:

> Ahmed S. Darwish wrote:

>> -		struct intmem_allocation* alloc =
>> -		  (struct intmem_allocation*)kmalloc(sizeof *alloc, GFP_KERNEL);
>> +		struct intmem_allocation* alloc = kmalloc(sizeof *alloc,
>> +							  GFP_KERNEL);
> 
> sizeof(*alloc) (see Documentation/CodingStyle)

Please do not advice that. The CodingStyle document only says "are 
usually used with parentheses in Linux, although they are not required 
in the language", nothing more. While for the most part a personal style 
issue, there are reasons for using "sizeof *ptr":

-- sizeof is not a function but an operator: you don't write
    "if (!(i))" or -(5) either.

-- it's usually "better" to sizeof the variable then it is to sizeof the
    type since it makes the code resistant to type changes (for
    instance foo_t -> struct foo changes)

Since you _do_ need the parens with a type, getting used to writing 
"sizeof foo" without them will then alert you and reader to the fact 
that something special is happening when you do see/use them.

If not enough of a reason to make "sizeof foo" the rule, please leave 
this up to personal preference.

Rene.


  reply index

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-01-05 10:26 Ahmed S. Darwish
2007-01-05 14:10 ` Mariusz Kozlowski
2007-01-08 12:10 ` Rolf Eike Beer
2007-01-08 13:54   ` Rene Herman [this message]
2007-01-08 19:21   ` Ahmed S. Darwish

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=45A24D1A.7020004@gmail.com \
    --to=rene.herman@gmail.com \
    --cc=darwish.07@gmail.com \
    --cc=eike-kernel@sf-tec.de \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

LKML Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lkml.kernel.org/lkml/0 lkml/git/0.git
	git clone --mirror https://lkml.kernel.org/lkml/1 lkml/git/1.git
	git clone --mirror https://lkml.kernel.org/lkml/2 lkml/git/2.git
	git clone --mirror https://lkml.kernel.org/lkml/3 lkml/git/3.git
	git clone --mirror https://lkml.kernel.org/lkml/4 lkml/git/4.git
	git clone --mirror https://lkml.kernel.org/lkml/5 lkml/git/5.git
	git clone --mirror https://lkml.kernel.org/lkml/6 lkml/git/6.git
	git clone --mirror https://lkml.kernel.org/lkml/7 lkml/git/7.git
	git clone --mirror https://lkml.kernel.org/lkml/8 lkml/git/8.git
	git clone --mirror https://lkml.kernel.org/lkml/9 lkml/git/9.git
	git clone --mirror https://lkml.kernel.org/lkml/10 lkml/git/10.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 lkml lkml/ https://lkml.kernel.org/lkml \
		linux-kernel@vger.kernel.org
	public-inbox-index lkml

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-kernel


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git