LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Jeff Layton <jlayton@poochiereds.net>
To: Eric Sandeen <sandeen@redhat.com>
Cc: Christoph Hellwig <hch@infradead.org>,
	Jeff Layton <jlayton@redhat.com>,
	linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
	esandeen@redhat.com, aviro@redhat.com
Subject: Re: [PATCH 2/3] change libfs sb creation routines to avoid collisions with their root inodes
Date: Thu, 11 Jan 2007 11:46:41 -0500	[thread overview]
Message-ID: <45A669F1.2050602@poochiereds.net> (raw)
In-Reply-To: <45A55FE5.80907@redhat.com>

Eric Sandeen wrote:
 > Christoph Hellwig wrote:
 >
 >>>  		return -ENOMEM;
 >>> +	/* set to high value to try and avoid collisions with loop below */
 >>> +	inode->i_ino = 0xffffffff;
 >>> +	insert_inode_hash(inode);
 >> This is odd.  Can't we just add some constant base to the loop below?
 >>
 > I thought the same thing, but Jeff pointed out that
 > nfsctl_transaction_write does ops based on inode numbers, and they maybe
 > can't move around?
 >
 >         rv =  write_op[ino](file, data, size);
 >
 > However, nfsd's call to simple_fill_super already sends in a set of
 > files starting at inode 2:
 >
 > enum {
 >         NFSD_Root = 1,
 >         NFSD_Svc,
 > ...
 >
 >         static struct tree_descr nfsd_files[] = {
 >                 [NFSD_Svc] = {".svc", &transaction_ops, S_IWUSR},
 > ...
 >         return simple_fill_super(sb, 0x6e667364, nfsd_files);
 >
 > which does...
 >
 >       for (i = 0; !files->name || files->name[0]; i++, files++) {
 >                 if (!files->name)
 >                         continue;
 > ...
 >                 inode->i_ino = i;
 >
 > So I think it's already expecting the root inode at one, and the other
 > files starting at 2?
 >

Very interesting -- I saw that nfsctl depended on certain values for i_ino,
but I didn't notice that it had reserved the first slot for NFSD_Root. The
only other caller of simple_fill_super that seems to depend on the inode
numbers is selinuxfs, and that one has this:

enum sel_inos {
         SEL_ROOT_INO = 2,

...so it looks like we can probably use 1 for the root inode (though we might
want to fix selinuxfs to set SEL_ROOT_INO = 1). I'll have a closer look to be
sure that this is all correct and respin this patch since that seems like it
would be less magic-number-y.

Thanks,
Jeff

  reply	other threads:[~2007-01-11 16:47 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-01-08 20:47 Jeff Layton
2007-01-10 21:22 ` Christoph Hellwig
2007-01-10 21:51   ` Eric Sandeen
2007-01-11 16:46     ` Jeff Layton [this message]
  -- strict thread matches above, loose matches on Subject: below --
2007-01-16 18:57 Jeff Layton
2007-01-11 20:15 Jeff Layton
2007-01-11 20:08 Jeff Layton
2007-01-11 19:43 Jeff Layton
2006-12-29 19:11 Jeff Layton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=45A669F1.2050602@poochiereds.net \
    --to=jlayton@poochiereds.net \
    --cc=aviro@redhat.com \
    --cc=esandeen@redhat.com \
    --cc=hch@infradead.org \
    --cc=jlayton@redhat.com \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sandeen@redhat.com \
    --subject='Re: [PATCH 2/3] change libfs sb creation routines to avoid collisions with their root inodes' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).