LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Michael Reed <mdr@sgi.com>
To: Andrew Morton <akpm@osdl.org>
Cc: "Chen, Kenneth W" <kenneth.w.chen@intel.com>,
	"'Zach Brown'" <zach.brown@oracle.com>,
	"'Chris Mason'" <chris.mason@oracle.com>,
	Christoph Hellwig <hch@infradead.org>,
	linux-kernel <linux-kernel@vger.kernel.org>,
	Jeremy Higdon <jeremy@sgi.com>, David Chinner <dgc@sgi.com>
Subject: Re: [patch] optimize o_direct on block device - v3
Date: Thu, 11 Jan 2007 14:43:43 -0600	[thread overview]
Message-ID: <45A6A17F.6080002@sgi.com> (raw)
In-Reply-To: <20070111112901.28085adf.akpm@osdl.org>


Andrew Morton wrote:
> On Thu, 11 Jan 2007 13:21:57 -0600
> Michael Reed <mdr@sgi.com> wrote:
> 
>> Testing on my ia64 system reveals that this patch introduces a
>> data integrity error for direct i/o to a block device.  Device
>> errors which result in i/o failure do not propagate to the
>> process issuing direct i/o to the device.
>>
>> This can be reproduced by doing writes to a fibre channel block
>> device and then disabling the switch port connecting the host
>> adapter to the switch.
>>
> 
> Does this fix it?
> 


Yes it does!  Thank you for finding this so quickly.

Mike


> <thwaps Ken>
> <thwaps compiler>
> <adds new entry to Documentation/SubmitChecklist>
> 
> diff -puN fs/block_dev.c~a fs/block_dev.c
> --- a/fs/block_dev.c~a
> +++ a/fs/block_dev.c
> @@ -146,7 +146,7 @@ static int blk_end_aio(struct bio *bio, 
>  		iocb->ki_nbytes = -EIO;
>  
>  	if (atomic_dec_and_test(bio_count)) {
> -		if (iocb->ki_nbytes < 0)
> +		if ((long)iocb->ki_nbytes < 0)
>  			aio_complete(iocb, iocb->ki_nbytes, 0);
>  		else
>  			aio_complete(iocb, iocb->ki_left, 0);
> _
> 
> 

  reply	other threads:[~2007-01-11 20:44 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-12-06 23:23 Chen, Kenneth W
2006-12-07 23:02 ` Zach Brown
2007-01-11 19:21 ` Michael Reed
2007-01-11 19:29   ` Andrew Morton
2007-01-11 20:43     ` Michael Reed [this message]
2007-01-11 21:36     ` Chen, Kenneth W
2007-01-11 21:44       ` Randy Dunlap
2007-01-11 21:51         ` Chen, Kenneth W
2007-01-19 18:14     ` Michael Reed
2007-01-19 21:30       ` Andrew Morton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=45A6A17F.6080002@sgi.com \
    --to=mdr@sgi.com \
    --cc=akpm@osdl.org \
    --cc=chris.mason@oracle.com \
    --cc=dgc@sgi.com \
    --cc=hch@infradead.org \
    --cc=jeremy@sgi.com \
    --cc=kenneth.w.chen@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=zach.brown@oracle.com \
    --subject='Re: [patch] optimize o_direct on block device - v3' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).