LKML Archive on
help / color / mirror / Atom feed
From: Tejun Heo <>
To: Alan <>
Subject: Re: Proposed changes for libata speed handling
Date: Sat, 13 Jan 2007 11:02:58 +0900	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <20070112135301.4cdba24f@localhost.localdomain>

Alan wrote:
> I'm currently hacking on the speed handling code a bit
> I'd like to do the following unless anyone has any objections
> - Remove post_set_mode and make drivers wrap the guts of the existing
> set_mode() function. This allows a driver to wrap and see success/failure
> while removing a callback, and also to add pre-mode code. (ie you'd do
> foo_set_mode() {
>     ata_default_set_mode()
>     my_fiddling();
> }
> - Fix the ->set_mode method FIXMEs in the current tree [DONE]
> - Add set_specific_mode, with a default behaviour that works for most
> controllers. Those using a private ->set_mode might need a private
> ->set_specific_mode, in some cases like it8212 simply to error the request
> - Hook set_specific_mode to the ata command parser so that instead of
> erroring set_features commands we snoop them and force the mode change
> desired on the controller (if valid)
> - Send the command to set the speed before setting the controller speed,
> so that we send them at the right rate.
> Any comments ?

Wouldn't it be better to have ->determine_xfer_mask() and
->set_specific_mode() than having two somewhat overlapping callbacks?
Or is there some problem that can't be handled that way?



  reply	other threads:[~2007-01-13  2:03 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-01-12 13:53 Proposed changes for libata speed handling Alan
2007-01-13  2:02 ` Tejun Heo [this message]
2007-01-13 10:01   ` Alan
2007-01-15  3:09     ` Tejun Heo
2007-01-15 13:52       ` Jeff Garzik

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).