LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* Proposed changes for libata speed handling
@ 2007-01-12 13:53 Alan
  2007-01-13  2:02 ` Tejun Heo
  0 siblings, 1 reply; 5+ messages in thread
From: Alan @ 2007-01-12 13:53 UTC (permalink / raw)
  To: linux-ide, linux-kernel

I'm currently hacking on the speed handling code a bit

I'd like to do the following unless anyone has any objections

- Remove post_set_mode and make drivers wrap the guts of the existing
set_mode() function. This allows a driver to wrap and see success/failure
while removing a callback, and also to add pre-mode code. (ie you'd do

foo_set_mode() {
    ata_default_set_mode()
    my_fiddling();
}

- Fix the ->set_mode method FIXMEs in the current tree [DONE]

- Add set_specific_mode, with a default behaviour that works for most
controllers. Those using a private ->set_mode might need a private
->set_specific_mode, in some cases like it8212 simply to error the request

- Hook set_specific_mode to the ata command parser so that instead of
erroring set_features commands we snoop them and force the mode change
desired on the controller (if valid)

- Send the command to set the speed before setting the controller speed,
so that we send them at the right rate.

Any comments ?

Alan

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2007-01-15 13:53 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2007-01-12 13:53 Proposed changes for libata speed handling Alan
2007-01-13  2:02 ` Tejun Heo
2007-01-13 10:01   ` Alan
2007-01-15  3:09     ` Tejun Heo
2007-01-15 13:52       ` Jeff Garzik

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).