LKML Archive on
help / color / mirror / Atom feed
From: Robert Hancock <>
To: linux-kernel <>,
Cc: Jeff Garzik <>, Allen Martin <>
Subject: Re: [PATCH -mm] sata_nv: cleanup ADMA error handling
Date: Mon, 15 Jan 2007 08:28:50 -0600	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

Robert Hancock wrote:
> -In the error_handler function the code would always go through and do 
> an ADMA channel reset and also dump out the state of all the CPBs. This 
> reset seems heinous in this situation since we haven't even decided to 
> reset anything yet. The output seems redundant at this point since 
> libata already dumps the state of all active commands on errors (and it 
> also triggers at times when it shouldn't, like when suspending). Do the 
> ADMA reset only on hardreset and remove the output.

Actually, upon further thought some of this stuff really should be done 
in the error_handler method, just maybe not the channel reset. I'll cut 
another patch shortly.

      reply	other threads:[~2007-01-15 14:31 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-01-15  2:40 Robert Hancock
2007-01-15 14:28 ` Robert Hancock [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \
    --subject='Re: [PATCH -mm] sata_nv: cleanup ADMA error handling' \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).