LKML Archive on
help / color / mirror / Atom feed
From: "H. Peter Anvin" <>
To: Mikael Pettersson <>
Subject: Re: [PATCH]: MTRR: fix 32-bit ioctls on x64_32
Date: Tue, 16 Jan 2007 19:51:53 -0800	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

Mikael Pettersson wrote:
> These #ifdefs are too ugly.
> Since you apparently just add aliases for the case labels,
> and do no actual code changes, why not
> 1. make the new cases unconditional, or 
> 2. invoke a translation function before the switch which
>    maps the MTRRCIOC32_ constants to what the kernel uses

Adding a case can add substantially to the generated code, especially if 
it makes a compact set of case labels non-compact.


  parent reply	other threads:[~2007-01-17  3:52 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-01-16 12:48 Mikael Pettersson
2007-01-16 17:59 ` Giuliano Procida
2007-01-17  3:51 ` H. Peter Anvin [this message]
2007-01-23 13:23   ` Giuliano Procida
  -- strict thread matches above, loose matches on Subject: below --
2007-01-16  8:14 Giuliano Procida

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \
    --subject='Re: [PATCH]: MTRR: fix 32-bit ioctls on x64_32' \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).