LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Cedric Le Goater <clg@fr.ibm.com>
To: Oleg Nesterov <oleg@tv-sign.ru>
Cc: Daniel Hokka Zakrisson <daniel@hozac.com>,
"Eric W. Biederman" <ebiederm@xmission.com>,
linux-kernel@vger.kernel.org, herbert@13thfloor.at,
akpm@osdl.org, trond.myklebust@fys.uio.no,
Linux Containers <containers@lists.osdl.org>
Subject: Re: NFS causing oops when freeing namespace
Date: Wed, 17 Jan 2007 20:20:37 +0100 [thread overview]
Message-ID: <45AE7705.4040603@fr.ibm.com> (raw)
In-Reply-To: <20070117185823.GA878@tv-sign.ru>
Oleg Nesterov wrote:
> On 01/17, Daniel Hokka Zakrisson wrote:
>>>> Call Trace:
>>>> [<c03be6f0>] _spin_lock_irqsave+0x20/0x90
>>>> [<c01f6115>] lockd_down+0x125/0x190
>>>> [<c01d26bd>] nfs_free_server+0x6d/0xd0
>>>> [<c01d8e9c>] nfs_kill_super+0xc/0x20
>>>> [<c0161c5d>] deactivate_super+0x7d/0xa0
>>>> [<c0175e0e>] release_mounts+0x6e/0x80
>>>> [<c0175e86>] __put_mnt_ns+0x66/0x80
>>>> [<c0132b3e>] free_nsproxy+0x5e/0x60
>>>> [<c011f021>] do_exit+0x791/0x810
>>>> [<c011f0c6>] do_group_exit+0x26/0x70
>>>> [<c0103142>] sysenter_past_esp+0x5f/0x85
>>>> [<c03b0033>] rpc_wake_up+0x3/0x70
>> It was the only semi-plausible explanation I could come up with. I added a
>> printk in do_exit right before exit_task_namespaces, where sighand was
>> still set, and one right before the spin_lock_irq in lockd_down, where it
>> had suddenly been set to NULL.
>
> I can't reproduce the problem, but
I did on a 2.6.20-rc4-mm1.
> do_exit:
> exit_notify(tsk);
> exit_task_namespaces(tsk);
>
> the task could be reaped by its parent in between.
indeed. while it goes spleeping in lockd_down() just before it does
spin_lock_irq(¤t->sighand->siglock);
current->sighand is valid before interruptible_sleep_on_timeout() and
not after.
> We should not use ->signal/->sighand after exit_notify().
>
> Can we move exit_task_namespaces() up?
yes but I moved it down because it invalidates ->nsproxy ...
C.
next prev parent reply other threads:[~2007-01-17 19:20 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-01-17 10:28 Daniel Hokka Zakrisson
2007-01-17 12:44 ` Eric W. Biederman
2007-01-17 13:13 ` Daniel Hokka Zakrisson
2007-01-17 18:58 ` Oleg Nesterov
2007-01-17 19:20 ` Cedric Le Goater [this message]
2007-01-17 19:46 ` Oleg Nesterov
2007-01-17 20:31 ` Cedric Le Goater
2007-01-17 22:30 ` Eric W. Biederman
2007-01-17 22:46 ` Trond Myklebust
2007-01-17 22:55 ` Oleg Nesterov
2007-01-18 4:46 ` Eric W. Biederman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45AE7705.4040603@fr.ibm.com \
--to=clg@fr.ibm.com \
--cc=akpm@osdl.org \
--cc=containers@lists.osdl.org \
--cc=daniel@hozac.com \
--cc=ebiederm@xmission.com \
--cc=herbert@13thfloor.at \
--cc=linux-kernel@vger.kernel.org \
--cc=oleg@tv-sign.ru \
--cc=trond.myklebust@fys.uio.no \
--subject='Re: NFS causing oops when freeing namespace' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).