LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [2.6 patch] make hdlc_setup() static again
@ 2007-01-11 13:48 Adrian Bunk
2007-01-19 3:01 ` Jeff Garzik
0 siblings, 1 reply; 4+ messages in thread
From: Adrian Bunk @ 2007-01-11 13:48 UTC (permalink / raw)
To: Andrew Morton; +Cc: Krzysztof Halasa, Jeff Garzik, linux-kernel, netdev
hdlc_setup was exported, but this export was never used.
If a driver using it actually shows up it can still be exported again.
Signed-off-by: Adrian Bunk <bunk@stusta.de>
Acked-by: Krzysztof Halasa <khc@pm.waw.pl>
---
This patch was already sent on:
- 25 Nov 2006
--- linux-2.6.19-rc6-mm1/drivers/net/wan/hdlc.c.old 2006-11-25 00:16:13.000000000 +0100
+++ linux-2.6.19-rc6-mm1/drivers/net/wan/hdlc.c 2006-11-25 00:16:26.000000000 +0100
@@ -222,7 +222,7 @@
return -EINVAL;
}
-void hdlc_setup(struct net_device *dev)
+static void hdlc_setup(struct net_device *dev)
{
hdlc_device *hdlc = dev_to_hdlc(dev);
@@ -325,7 +325,6 @@
EXPORT_SYMBOL(hdlc_open);
EXPORT_SYMBOL(hdlc_close);
EXPORT_SYMBOL(hdlc_ioctl);
-EXPORT_SYMBOL(hdlc_setup);
EXPORT_SYMBOL(alloc_hdlcdev);
EXPORT_SYMBOL(unregister_hdlc_device);
EXPORT_SYMBOL(register_hdlc_protocol);
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [2.6 patch] make hdlc_setup() static again
2007-01-11 13:48 [2.6 patch] make hdlc_setup() static again Adrian Bunk
@ 2007-01-19 3:01 ` Jeff Garzik
0 siblings, 0 replies; 4+ messages in thread
From: Jeff Garzik @ 2007-01-19 3:01 UTC (permalink / raw)
To: Adrian Bunk; +Cc: Andrew Morton, Krzysztof Halasa, linux-kernel, netdev
Adrian Bunk wrote:
> hdlc_setup was exported, but this export was never used.
>
> If a driver using it actually shows up it can still be exported again.
>
> Signed-off-by: Adrian Bunk <bunk@stusta.de>
> Acked-by: Krzysztof Halasa <khc@pm.waw.pl>
applied
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [2.6 patch] make hdlc_setup() static again
2006-11-25 19:16 ` [2.6 patch] make hdlc_setup() static again Adrian Bunk
@ 2006-11-26 19:22 ` Krzysztof Halasa
0 siblings, 0 replies; 4+ messages in thread
From: Krzysztof Halasa @ 2006-11-26 19:22 UTC (permalink / raw)
To: Adrian Bunk; +Cc: Jeff Garzik, linux-kernel, netdev
Adrian Bunk <bunk@stusta.de> writes:
> It's still not used...
>
> So let's unexport it again until some driver that actually uses it shows up.
Fair enough.
--
Krzysztof Halasa
^ permalink raw reply [flat|nested] 4+ messages in thread
* [2.6 patch] make hdlc_setup() static again
2006-06-26 19:28 ` Krzysztof Halasa
@ 2006-11-25 19:16 ` Adrian Bunk
2006-11-26 19:22 ` Krzysztof Halasa
0 siblings, 1 reply; 4+ messages in thread
From: Adrian Bunk @ 2006-11-25 19:16 UTC (permalink / raw)
To: Krzysztof Halasa; +Cc: Jeff Garzik, linux-kernel, netdev
On Mon, Jun 26, 2006 at 09:28:14PM +0200, Krzysztof Halasa wrote:
> Adrian Bunk <bunk@stusta.de> writes:
>
> > hdlc_setup() is now EXPORTed as per David's request.
> >
> > Is a usage of this export pending for the near future
>
> I'm told it is.
It's still not used...
So let's unexport it again until some driver that actually uses it shows up.
> Krzysztof Halasa
cu
Adrian
<-- snip -->
hdlc_setup was exported, but this export was never used.
If adriver using it actually shows up it can still be exported again.
Signed-off-by: Adrian Bunk <bunk@stusta.de>
--- linux-2.6.19-rc6-mm1/drivers/net/wan/hdlc.c.old 2006-11-25 00:16:13.000000000 +0100
+++ linux-2.6.19-rc6-mm1/drivers/net/wan/hdlc.c 2006-11-25 00:16:26.000000000 +0100
@@ -222,7 +222,7 @@
return -EINVAL;
}
-void hdlc_setup(struct net_device *dev)
+static void hdlc_setup(struct net_device *dev)
{
hdlc_device *hdlc = dev_to_hdlc(dev);
@@ -325,7 +325,6 @@
EXPORT_SYMBOL(hdlc_open);
EXPORT_SYMBOL(hdlc_close);
EXPORT_SYMBOL(hdlc_ioctl);
-EXPORT_SYMBOL(hdlc_setup);
EXPORT_SYMBOL(alloc_hdlcdev);
EXPORT_SYMBOL(unregister_hdlc_device);
EXPORT_SYMBOL(register_hdlc_protocol);
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2007-01-19 3:01 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2007-01-11 13:48 [2.6 patch] make hdlc_setup() static again Adrian Bunk
2007-01-19 3:01 ` Jeff Garzik
-- strict thread matches above, loose matches on Subject: below --
2006-06-25 20:51 -git: Why is drivers/net/wan/hdlc_generic.c:hdlc_setup() exported? Adrian Bunk
2006-06-26 19:28 ` Krzysztof Halasa
2006-11-25 19:16 ` [2.6 patch] make hdlc_setup() static again Adrian Bunk
2006-11-26 19:22 ` Krzysztof Halasa
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).