LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Robert Hancock <hancockr@shaw.ca>
To: pomac@vapor.com
Cc: Linux-kernel@vger.kernel.org, jeff@garzik.org,
	B.Steinbrink@gmx.de, s0348365@sms.ed.ac.uk, chunkeey@web.de
Subject: Re: SATA exceptions with 2.6.20-rc5
Date: Sat, 20 Jan 2007 13:59:07 -0600	[thread overview]
Message-ID: <45B2748B.4060106@shaw.ca> (raw)
In-Reply-To: <1169305408.4199.3.camel@pi.pomac.com>

Ian Kumlien wrote:
> Hi,
> 
> I went from 2.6.19+sata_nv-adma-ncq-v7.patch, with no problems and adama
> enabled, to 2.6.20-rc5, which gave me problems almost instantly.
> 
> I just thought that it might be interesting to know that it DID work
> nicely.
> 
> CC since i'm not on the ml
> 

(I'm ccing more of the people who reported this)

Well that's interesting.. The only significant change that went into 
2.6.20-rc5 in that driver that wasn't in that version you mentioned was 
this one:

http://www2.kernel.org/git/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=2dec7555e6bf2772749113ea0ad454fcdb8cf861

Could you (or anyone else) test what happens if you take the 2.6.20-rc5 
version of sata_nv.c and try it on 2.6.19? That would tell us whether 
it's this change or whether it's something else (i.e. in libata core).

Assuming that still doesn't work, can you then try removing these lines 
from nv_host_intr in 2.6.20-rc5 sata_nv.c and see what that does?

	/* bail out if not our interrupt */
	if (!(irq_stat & NV_INT_DEV))
		return 0;

as that's the difference I'm most suspicious of causing the problem.

-- 
Robert Hancock      Saskatoon, SK, Canada
To email, remove "nospam" from hancockr@nospamshaw.ca
Home Page: http://www.roberthancock.com/


  reply	other threads:[~2007-01-20 19:59 UTC|newest]

Thread overview: 71+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-01-20 15:03 Ian Kumlien
2007-01-20 19:59 ` Robert Hancock [this message]
2007-01-20 21:43   ` Alistair John Strachan
2007-01-20 22:11     ` Ian Kumlien
     [not found] <fa.1kBz5luWz8nR0lLqm1VD4hZZYdw@ifi.uio.no>
     [not found] ` <fa.QZxgjxcwtENaZNY24NMTlKBSgIM@ifi.uio.no>
     [not found]   ` <fa.fkPTbUGmKc/1pt0eD6TE4d02n+Q@ifi.uio.no>
     [not found]     ` <fa.6iQt5OtHZ3x5w8eYbLxwULhLTJ0@ifi.uio.no>
     [not found]       ` <fa.1aqo3IxNGJClHcBVZNTagX6bL9o@ifi.uio.no>
     [not found]         ` <fa.rI60BGlFbSyfLyumqmgiOfDqCI4@ifi.uio.no>
2007-01-23 23:18           ` Robert Hancock
2007-01-24  0:39             ` Björn Steinbrink
2007-02-03  1:42               ` Björn Steinbrink
2007-02-03  5:48                 ` Robert Hancock
2007-02-04  1:13                   ` Björn Steinbrink
2007-02-09 12:03                     ` Björn Steinbrink
2007-01-24  8:24             ` Ian Kumlien
2007-01-24 14:41               ` Björn Steinbrink
     [not found] <fa.ow4pXUncgdZmfLf3oyfrn1W+Bk0@ifi.uio.no>
     [not found] ` <fa.SoSeidhDuEr/K0kN+L4vW61Vpnc@ifi.uio.no>
     [not found]   ` <fa.m8QbVQMhuOshKzTdlSjNjOhaNcc@ifi.uio.no>
     [not found]     ` <fa.hDS02YCM8Tv1/STeTpJGEQD/49s@ifi.uio.no>
     [not found]       ` <fa.eqBbU9XvtTizNMpuUjctnk8vuOI@ifi.uio.no>
     [not found]         ` <fa.4QxeKMcmkoyhlL26AivZV6BFQJQ@ifi.uio.no>
2007-01-23  1:24           ` Robert Hancock
2007-01-23  1:34             ` Alistair John Strachan
2007-01-23  1:41               ` Robert Hancock
2007-01-23 15:29                 ` Larry Walton
2007-01-23  2:44             ` Björn Steinbrink
2007-01-23  5:03               ` Robert Hancock
     [not found] <fa.U/G88R1fWKOeQK3EBPHKK4MeRsQ@ifi.uio.no>
     [not found] ` <fa.2D0TIXbVTOgZmGg9ZJU+R7te70k@ifi.uio.no>
     [not found]   ` <fa.hMhdefkReYJ4idUyqqEWJFnWUBE@ifi.uio.no>
     [not found]     ` <fa.8TPWeOrcwkkHutPX5NOcJsTBO8Y@ifi.uio.no>
     [not found]       ` <fa.b92BqwV090pDj7q0iBG6BChksbI@ifi.uio.no>
     [not found]         ` <fa.O3RzvckSjB73Y0uL8P1nTXDRd6U@ifi.uio.no>
2007-01-19  0:09           ` Robert Hancock
2007-01-19  0:52             ` Björn Steinbrink
     [not found] <fa.hif5u4ZXua+b0mVNaWEcItWv9i0@ifi.uio.no>
2007-01-14 23:43 ` Robert Hancock
2007-01-15  0:22   ` Jeff Garzik
2007-01-15  0:34     ` Björn Steinbrink
2007-01-15  2:47       ` Björn Steinbrink
2007-01-15  2:25     ` Robert Hancock
2007-01-15  2:53       ` Jens Axboe
2007-01-15 13:42         ` Jeff Garzik
2007-01-16  0:23           ` Jens Axboe
2007-01-16  0:36             ` Robert Hancock
2007-01-16  1:51               ` Jeff Garzik
2007-01-16  1:51             ` Jeff Garzik
2007-01-22 18:17               ` Eric D. Mudama
2007-01-15 21:17   ` Björn Steinbrink
2007-01-15 23:46     ` Björn Steinbrink
2007-01-16  0:34       ` Robert Hancock
2007-01-16  1:35         ` Björn Steinbrink
2007-01-16  3:00           ` Robert Hancock
2007-01-16  1:53         ` Jeff Garzik
2007-01-19 15:05           ` Alistair John Strachan
2007-01-19 19:51             ` chunkeey
2007-01-20  2:41             ` Robert Hancock
2007-01-20  2:47               ` Alistair John Strachan
2007-01-20  4:15               ` Björn Steinbrink
     [not found]               ` <20070120072755.GA4652@atjola.homenet>
2007-01-20  7:50                 ` Björn Steinbrink
2007-01-20 18:50               ` Chr
2007-01-20 22:32               ` Chr
2007-01-21  1:50                 ` Robert Hancock
2007-01-21  3:34                   ` Jeff Garzik
2007-01-21  4:54                     ` Björn Steinbrink
2007-01-21  6:39                       ` Robert Hancock
2007-01-21  8:36                         ` Björn Steinbrink
2007-01-21 17:34                           ` Chr
2007-01-21 18:01                             ` Björn Steinbrink
2007-01-21 20:13                               ` Chr
2007-01-22  2:39                                 ` Tejun Heo
2007-01-22 12:32                                   ` Chr
2007-01-21 18:40                           ` Björn Steinbrink
2007-01-21 19:58                             ` Robert Hancock
2007-01-21 22:08                               ` Björn Steinbrink
2007-01-21 22:11                                 ` Björn Steinbrink
2007-01-21 22:26                                   ` Robert Hancock
2007-01-21 22:27                               ` Björn Steinbrink
2007-01-22  0:17                                 ` Robert Hancock
2007-01-22 16:12                                   ` Björn Steinbrink
2007-01-22 16:57                                     ` Björn Steinbrink
2007-01-22 17:53                                       ` Björn Steinbrink
2007-01-19 14:53         ` Alistair John Strachan
  -- strict thread matches above, loose matches on Subject: below --
2007-01-14 22:44 Björn Steinbrink
2007-01-15  6:48 ` Mikael Pettersson
2007-01-15 13:43   ` Jeff Garzik
2007-01-15 13:47   ` Björn Steinbrink

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=45B2748B.4060106@shaw.ca \
    --to=hancockr@shaw.ca \
    --cc=B.Steinbrink@gmx.de \
    --cc=Linux-kernel@vger.kernel.org \
    --cc=chunkeey@web.de \
    --cc=jeff@garzik.org \
    --cc=pomac@vapor.com \
    --cc=s0348365@sms.ed.ac.uk \
    --subject='Re: SATA exceptions with 2.6.20-rc5' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).