LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Michael Krufky <mkrufky@linuxtv.org>
To: Chris Rankin <rankincj@yahoo.com>
Cc: v4l-dvb-maintainer@linuxtv.org, linux-dvb@linuxtv.org,
	linux-kernel@vger.kernel.org
Subject: Re: [v4l-dvb-maintainer] [PATCH] Register the bus,	vendor and product IDs for dvb-usb remote device
Date: Sun, 21 Jan 2007 14:12:38 -0500	[thread overview]
Message-ID: <45B3BB26.7000208@linuxtv.org> (raw)
In-Reply-To: <879469.96393.qm@web52901.mail.yahoo.com>

Chris Rankin wrote:
> Hi,
>
> This patch writes the USB vendor and product IDs into the /sys/class/input/inputX/id/ files, so
> that udev can find them. A rule like this does the trick for me:
>
> KERNEL="event*", SYSFS{../id/vendor}=="2040", SYSFS{../id/product}=="9301",
> SYMLINK+="input/dvb-remote"
>
> --- linux-2.6.18/drivers/media/dvb/dvb-usb/dvb-usb-remote.c.old 2007-01-21 02:43:11.000000000
> +0000
> +++ linux-2.6.18/drivers/media/dvb/dvb-usb/dvb-usb-remote.c     2007-01-21 02:39:02.000000000
> +0000
> @@ -107,6 +107,9 @@
>         d->rc_input_dev->keycodemax = KEY_MAX;
>         d->rc_input_dev->name = "IR-receiver inside an USB DVB receiver";
>         d->rc_input_dev->phys = d->rc_phys;
> +       d->rc_input_dev->id.bustype = BUS_USB;
> +       d->rc_input_dev->id.vendor = d->udev->descriptor.idVendor;
> +       d->rc_input_dev->id.product = d->udev->descriptor.idProduct;
>
>         /* set the bits for the keys */
>         deb_rc("key map size: %d\n", d->props.rc_key_map_size);

Chris,

The patch is fine.  Could you please provide a sign-off, in the form:

Signed-off-by: Your Name <email@addre.ss>

...so that we can apply this to the kernel sources?

Cheers,

Mike Krufky

      reply	other threads:[~2007-01-22  5:24 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-01-21  2:47 Chris Rankin
2007-01-21 19:12 ` Michael Krufky [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=45B3BB26.7000208@linuxtv.org \
    --to=mkrufky@linuxtv.org \
    --cc=linux-dvb@linuxtv.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rankincj@yahoo.com \
    --cc=v4l-dvb-maintainer@linuxtv.org \
    --subject='Re: [v4l-dvb-maintainer] [PATCH] Register the bus,	vendor and product IDs for dvb-usb remote device' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).