LKML Archive on
help / color / mirror / Atom feed
From: Auke Kok <>
To: Frederik Deweerdt <>
Cc: Andrei Popa <>,,,
	NetDev <>
Subject: Re: [BUG] e100: eth0 appers many times in /proc/interrupts after resume
Date: Mon, 22 Jan 2007 16:15:29 -0800	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <20070121220457.GC8958@slug>

Frederik Deweerdt wrote:
> On Sun, Jan 21, 2007 at 01:45:27PM -0800, Auke Kok wrote:
>> Frederik Deweerdt wrote:
>>> On Sun, Jan 21, 2007 at 09:17:41PM +0200, Andrei Popa wrote:
>>>> It's the 10th resume and in /proc/interrupts eth0 appers 10 times.
>>> The e100_resume() function should be calling netif_device_detach and
>>> free_irq. Could you try the following (compile tested) patch?
>> I just fixed suspend/shutdown for e100 in 2.6.19, not sure why the problem still shows up. Since it's a driver/net issue, you 
>> should CC netdev on it tho, otherwise it might go unnoticed.
> Thanks for adding the CC
>> I'll open up the can-o-worms on this issue and see what's up with it.
>> I'm not so sure that this patch is OK, and I wonder why it stopped working, because I spent quite some time fixing it only a 
>> few months ago. Did swsup change again? sigh...
> I may well be wrong (It appears that most of the time I am :)), but the
> unbalanced netif_device_attach (in resume) looks suspicious.  resume()
> also calls request_irq, so calling free_irq on suspend seemed logical.

I just tested the patch and looked it over again. The patch works good and 
indeed fixes the problem, and netconsole works great. It even shows much of the 
suspend/resume over the wire, something which I can't remember seeing before 
with netconsole. reboot -f also works OK.

I'll push the patch upstream, thanks!


  reply	other threads:[~2007-01-23  0:15 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1167478664.8521.2.camel@localhost>
     [not found] ` <>
     [not found]   ` <1167480259.8855.3.camel@localhost>
     [not found]     ` <>
     [not found]       ` <1167515552.30176.4.camel@localhost>
     [not found]         ` <>
     [not found]           ` <1167518608.7177.0.camel@localhost>
     [not found]             ` <>
     [not found]               ` <1167571281.7175.1.camel@localhost>
     [not found]                 ` <>
     [not found]                   ` <1167605481.12328.0.camel@localhost>
     [not found]                     ` <>
     [not found]                       ` <1167644970.7142.6.camel@localhost>
     [not found]                         ` <>
     [not found]                           ` <1168448689.7430.1.camel@localhost>
     [not found]                             ` <>
2007-01-21 19:17                               ` [BUG] " Andrei Popa
2007-01-21 21:22                                 ` Frederik Deweerdt
2007-01-21 21:45                                   ` [BUG] e100: " Auke Kok
2007-01-21 22:04                                     ` Frederik Deweerdt
2007-01-23  0:15                                       ` Auke Kok [this message]
2007-01-23  9:12                                   ` [BUG] " Andrei Popa

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \ \
    --subject='Re: [BUG] e100: eth0 appers many times in /proc/interrupts after resume' \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).