LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH] mmc: au1xmmc: return errors for unknown response types
@ 2007-01-25 9:27 Manuel Lauss
2007-01-27 13:01 ` Pierre Ossman
0 siblings, 1 reply; 2+ messages in thread
From: Manuel Lauss @ 2007-01-25 9:27 UTC (permalink / raw)
To: drzeus-mmc; +Cc: linux-kernel
au1xmmc: return error when encountering unhandled/unknown response type.
Signed-off-by: Manuel Lauss <mano@roarinelk.homelinux.net>
--- a/drivers/mmc/au1xmmc.c.orig 2007-01-25 09:56:10.851983000 +0100
+++ b/drivers/mmc/au1xmmc.c 2007-01-25 10:13:12.121983000 +0100
@@ -193,6 +194,8 @@ static int au1xmmc_send_command(struct a
u32 mmccmd = (cmd->opcode << SD_CMD_CI_SHIFT);
switch (mmc_resp_type(cmd)) {
+ case MMC_RSP_NONE:
+ break;
case MMC_RSP_R1:
mmccmd |= SD_CMD_RT_1;
break;
@@ -205,6 +208,10 @@ static int au1xmmc_send_command(struct a
case MMC_RSP_R3:
mmccmd |= SD_CMD_RT_3;
break;
+ default:
+ printk(KERN_INFO "au1xmmc: unhandled response type %02x\n",
+ mmc_resp_type(cmd));
+ return MMC_ERR_INVALID;
}
switch(cmd->opcode) {
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] mmc: au1xmmc: return errors for unknown response types
2007-01-25 9:27 [PATCH] mmc: au1xmmc: return errors for unknown response types Manuel Lauss
@ 2007-01-27 13:01 ` Pierre Ossman
0 siblings, 0 replies; 2+ messages in thread
From: Pierre Ossman @ 2007-01-27 13:01 UTC (permalink / raw)
To: Manuel Lauss; +Cc: linux-kernel
Manuel Lauss wrote:
> au1xmmc: return error when encountering unhandled/unknown response type.
>
> Signed-off-by: Manuel Lauss <mano@roarinelk.homelinux.net>
>
Thanks, applied.
--
-- Pierre Ossman
Linux kernel, MMC maintainer http://www.kernel.org
PulseAudio, core developer http://pulseaudio.org
rdesktop, core developer http://www.rdesktop.org
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2007-01-27 13:01 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2007-01-25 9:27 [PATCH] mmc: au1xmmc: return errors for unknown response types Manuel Lauss
2007-01-27 13:01 ` Pierre Ossman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).