LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Pieter Palmers <pieterp@joow.be>
To: Stefan Richter <stefanr@s5r6.in-berlin.de>
Cc: Dan Dennedy <dan@dennedy.org>,
	linux1394-devel@lists.sourceforge.net,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH update] ieee1394: cycle timer read extension for	raw1394/libraw1394
Date: Sat, 03 Feb 2007 15:22:00 +0100	[thread overview]
Message-ID: <45C49A88.4050809@joow.be> (raw)
In-Reply-To: <tkrat.e06f68103e99e517@s5r6.in-berlin.de>

Stefan Richter wrote:
> From: Pieter Palmers <pieterp@joow.be>
> 
> This implements the simultaneous read of the isochronous cycle timer and
> the system clock (in usecs).  This allows to express the exact receive
> time of an ISO packet as a system time with microsecond accuracy.
> http://bugzilla.kernel.org/show_bug.cgi?id=7773
> 
> The counterpart patch for libraw1394 can be found at
> http://thread.gmane.org/gmane.linux.kernel.firewire.devel/8934
> 
> Patch update (Stefan R.):
>   - Disable preemption and local interrupts.
>   - Fix integer overflow.
I had to use 1000000ULL instead of USEC_PER_SEC to avoid weird behavior.

>   - Add paranoid error checks and kerneldoc to hpsb_read_cycle_timer.
>     Move it to other ieee1394_core high-level API functions.
>   - Rename userspace-exported struct _raw1394_cycle_timer to
>     raw1394_cycle_timer.  Change comments in raw1394.
>   - Adjust whitespace.
Thanks for the cleanups!

I can't test it right now, but I'll report later.

Pieter

  parent reply	other threads:[~2007-02-03 14:27 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <45BA5CFD.6070900@joow.be>
2007-01-27 10:21 ` [RFC] " Stefan Richter
2007-01-27 10:45   ` Pieter Palmers
2007-01-27 12:48     ` Stefan Richter
2007-02-03 12:58       ` [PATCH update] ieee1394: " Stefan Richter
2007-02-03 13:42         ` which header for local_irq_save? (was Re: [PATCH update] ieee1394: cycle timer read extension for raw1394/libraw1394) Stefan Richter
2007-02-03 14:22         ` Pieter Palmers [this message]
2007-02-03 15:32           ` [PATCH update] ieee1394: cycle timer read extension for raw1394/libraw1394 Stefan Richter
2007-02-04 12:55             ` Pieter Palmers
2007-02-03 16:42         ` Stefan Richter
2007-02-03 19:03         ` Stefan Richter
2007-02-03 20:18           ` Pieter Palmers
2007-02-10 14:20         ` compat_ioctl (was [PATCH update] ieee1394: cycle timer read extension for raw1394/libraw1394) Stefan Richter
2007-02-10 15:47           ` Arnd Bergmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=45C49A88.4050809@joow.be \
    --to=pieterp@joow.be \
    --cc=dan@dennedy.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux1394-devel@lists.sourceforge.net \
    --cc=stefanr@s5r6.in-berlin.de \
    --subject='Re: [PATCH update] ieee1394: cycle timer read extension for	raw1394/libraw1394' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).