LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Pieter Palmers <pieterp@joow.be>
To: Stefan Richter <stefanr@s5r6.in-berlin.de>
Cc: Dan Dennedy <dan@dennedy.org>,
	linux1394-devel@lists.sourceforge.net,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH update] ieee1394: cycle timer read extension for raw1394/libraw1394
Date: Sat, 03 Feb 2007 21:18:01 +0100	[thread overview]
Message-ID: <45C4EDF9.7050804@joow.be> (raw)
In-Reply-To: <45C4DC97.3050101@s5r6.in-berlin.de>

Stefan Richter wrote:
> I wrote:
>> +++ linux/drivers/ieee1394/raw1394.h	2007-02-03 13:47:34.000000000 +0100
>> @@ -178,4 +178,14 @@ struct raw1394_iso_status {
>>  	__s16 xmit_cycle;
>>  };
>>  
>> +/* argument to RAW1394_IOC_GET_CYCLE_TIMER ioctl */
>> +struct raw1394_cycle_timer {
>> +	/* contents of Isochronous Cycle Timer register,
>> +	   as in OHCI 1.1 clause 5.13 (also with non-OHCI hosts) */
>> +	__u32 cycle_timer;
>> +
>> +	/* local time in microseconds since Epoch,
>> +	   simultaneously read with cycle timer */
>> +	__u64 local_time;
>> +};
>>  #endif /* IEEE1394_RAW1394_H */
> 
> Pieter,
> one more thing. Do you want to hand out the cycle_timer bitfield to
> userspace as-is, or would it make sense to postprocess it in some way?
I like it as is. most of the time I convert it into ticks, but sometimes 
I just need the cycles.

Another reason not to postprocess is that it gives userspace more 
freedom in how accurate they want to use the cycle time. I'm probably 
going to throw away the seconds field altogether, because one second is 
a huge timeframe in my application. Throwing away the seconds field 
saves me quite some calculations.

Pieter

  reply	other threads:[~2007-02-03 20:21 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <45BA5CFD.6070900@joow.be>
2007-01-27 10:21 ` [RFC] " Stefan Richter
2007-01-27 10:45   ` Pieter Palmers
2007-01-27 12:48     ` Stefan Richter
2007-02-03 12:58       ` [PATCH update] ieee1394: " Stefan Richter
2007-02-03 13:42         ` which header for local_irq_save? (was Re: [PATCH update] ieee1394: cycle timer read extension for raw1394/libraw1394) Stefan Richter
2007-02-03 14:22         ` [PATCH update] ieee1394: cycle timer read extension for raw1394/libraw1394 Pieter Palmers
2007-02-03 15:32           ` Stefan Richter
2007-02-04 12:55             ` Pieter Palmers
2007-02-03 16:42         ` Stefan Richter
2007-02-03 19:03         ` Stefan Richter
2007-02-03 20:18           ` Pieter Palmers [this message]
2007-02-10 14:20         ` compat_ioctl (was [PATCH update] ieee1394: cycle timer read extension for raw1394/libraw1394) Stefan Richter
2007-02-10 15:47           ` Arnd Bergmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=45C4EDF9.7050804@joow.be \
    --to=pieterp@joow.be \
    --cc=dan@dennedy.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux1394-devel@lists.sourceforge.net \
    --cc=stefanr@s5r6.in-berlin.de \
    --subject='Re: [PATCH update] ieee1394: cycle timer read extension for raw1394/libraw1394' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).