LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: akuster <akuster@mvista.com>
To: Christoph Hellwig <hch@infradead.org>,
	akuster@mvista.com, linux-kernel@vger.kernel.org, akpm@osdl.org
Subject: Re: [patch 1/1] PM: Adds remount fs ro at suspend
Date: Sat, 03 Feb 2007 15:34:57 -1000	[thread overview]
Message-ID: <45C53841.5000505@mvista.com> (raw)
In-Reply-To: <20070203100848.GA28806@infradead.org>



Christoph Hellwig wrote:
> On Fri, Feb 02, 2007 at 01:50:10PM -1000, akuster@mvista.com wrote:
>>
>> This adds the ability for the file system to remounted as read only during a
>> system suspend.  Log the mount points so when the resume occurs, they can be 
>> remounted back to their original states. This is so in an advent of a power
>> failure, we try our best to keep data from being corrupted or lost.
> 
> Can you please explain why this can't be done in userspace?  

I am sure it can.  The idea came from customer inputs, speed is my 
guess. echo mem > /sys/../state seems a whole lot simpler and cleaner 
than having userspace figure out what it mounted and then doing echo mem.

In fact
> all existing suspend solutions seem to be doing fine doing things like
> this in userspace.

I guess I missed that boat. If you don't mind, could you point at one 
solution.

> 
>> +static struct suspremount *suspremount_list;
>> +
< snipped>

>> +void suspend_remount_all_fs_ro(void)
>> +{
>> +	suspremount_list = NULL;
>> +	emergency_remount();
> 
> NACK.  emergency_remount is exactly what it sais and should never ever
> be used for a system that you want to keep on using later on.  

The code "emergency_remount" is almost identical to what we have been 
using. I wanted to reuse existing code rather than dup it.

If you
> look at it's implementation it's not correct and can't serve as more than
> a bandaid for susrq. 

 From our customer experience, we have not gotten an bad feedback on it. 
  It seems to address there needs.

  In fact we should probably just remove it..
> 
>> +EXPORT_SYMBOL(suspend_remount_all_fs_ro);
> 
> And something like this for sure should not be exported.
> 
>> +EXPORT_SYMBOL(resume_remount_fs_rw);
> 
> ditto.
> 

All the code corrects have been address in my upcoming version.

Many thanks for you time and feedback.

Armin

  reply	other threads:[~2007-02-04  1:36 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-02-02 23:50 akuster
2007-02-03  0:16 ` Andrew Morton
2007-02-03  0:35   ` Henrique de Moraes Holschuh
2007-02-05 21:28     ` Nigel Cunningham
2007-02-05 21:35       ` Christoph Hellwig
2007-02-06 14:32       ` Henrique de Moraes Holschuh
2007-02-06 18:07         ` Rafael J. Wysocki
2007-02-06 21:38         ` Nigel Cunningham
2007-02-07 11:25           ` Henrique de Moraes Holschuh
2007-02-07 11:43             ` Nigel Cunningham
2007-02-07 12:05               ` Henrique de Moraes Holschuh
2007-02-07 14:10                 ` Rafael J. Wysocki
2007-02-09 22:24             ` Pavel Machek
2007-02-13 12:12         ` Pavel Machek
2007-02-03  0:57   ` akuster
2007-02-03 10:08 ` Christoph Hellwig
2007-02-04  1:34   ` akuster [this message]
2007-02-05 16:56     ` Christoph Hellwig
2007-02-14 11:07     ` Pavel Machek
2007-02-03 16:19 ` Pavel Machek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=45C53841.5000505@mvista.com \
    --to=akuster@mvista.com \
    --cc=akpm@osdl.org \
    --cc=hch@infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --subject='Re: [patch 1/1] PM: Adds remount fs ro at suspend' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).