LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Pierre Ossman <drzeus-list@drzeus.cx>
To: Alex Dubov <oakad@yahoo.com>
Cc: LKML <linux-kernel@vger.kernel.org>
Subject: Re: [RFC] [PATCH] Fix up needless kmap:s
Date: Sun, 04 Feb 2007 17:49:58 +0100	[thread overview]
Message-ID: <45C60EB6.1060104@drzeus.cx> (raw)
In-Reply-To: <147773.6460.qm@web36702.mail.mud.yahoo.com>

Alex Dubov wrote:
> The patch looks ok.
>
> However, due to certain peculiarities with memorystick and xd I have to emulate a scatter-gather
> in software. Considering that this particular aspect of implementation is the same for all card
> types on this TI chip, it can be shared by tifm_sd driver as well. In this case highmem won't be
> needed to be avoided and kmap_atomic will come back (may be).
>
>   

Fair enough. Just make sure you handle the big problem case (kmap only
maps a single page, not the entire sg entry).

> And, by the way, to what extent pagefault_enable/pagefault_disable calls are needed? They are
> present in k(u)map_atomic even for non-highmem pages/architectures.
>
>   

They tell the page fault handler that it may not sleep on a page fault.
Currently it only has the behaviour of disabling preemption though. I'd
guess it is present for non-highmem so that things behave somewhat
similar for both the highmem and non-highmem cases.

Rgds

-- 
     -- Pierre Ossman

  Linux kernel, MMC maintainer        http://www.kernel.org
  PulseAudio, core developer          http://pulseaudio.org
  rdesktop, core developer          http://www.rdesktop.org


      reply	other threads:[~2007-02-04 16:50 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-02-03 13:55 Pierre Ossman
2007-02-04  2:03 ` Alex Dubov
2007-02-04 16:49   ` Pierre Ossman [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=45C60EB6.1060104@drzeus.cx \
    --to=drzeus-list@drzeus.cx \
    --cc=linux-kernel@vger.kernel.org \
    --cc=oakad@yahoo.com \
    --subject='Re: [RFC] [PATCH] Fix up needless kmap:s' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).