LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Larry Finger <larry.finger@lwfinger.net>
To: roucaries bastien <roucaries.bastien@gmail.com>
Cc: Matthew Garrett <mjg59@srcf.ucam.org>,
	bcm43xx devel <Bcm43xx-dev@lists.berlios.de>,
	LKML <linux-kernel@vger.kernel.org>, Pavel Machek <pavel@ucw.cz>
Subject: Re: Bcm43xx oops after suspend to disk
Date: Sun, 04 Feb 2007 11:42:33 -0600	[thread overview]
Message-ID: <45C61B09.7010102@lwfinger.net> (raw)
In-Reply-To: <195c7a900702040907y8b8eff0gc8b0bbddd79a6792@mail.gmail.com>

roucaries bastien wrote:
> 
> Sorry for the delay it works. This time I can use iwlist eth scan.
> I have some difficulties to associate and I need to rmmod/modprobe in
> order to associate but it is another problem linked to a really weak
> power.

Bastien,

Please try this patch instead.

Thanks,

Larry

============================

Index: wireless-2.6/drivers/net/wireless/bcm43xx/bcm43xx_main.c
===================================================================
--- wireless-2.6.orig/drivers/net/wireless/bcm43xx/bcm43xx_main.c
+++ wireless-2.6/drivers/net/wireless/bcm43xx/bcm43xx_main.c
@@ -3638,6 +3638,7 @@ error:
 static int bcm43xx_init_board(struct bcm43xx_private *bcm)
 {
 	int err;
+	struct bcm43xx_phyinfo *phy = bcm43xx_current_phy(bcm);

 	mutex_lock(&(bcm)->mutex);

@@ -3658,6 +3659,8 @@ static int bcm43xx_init_board(struct bcm
 	if (err)
 		goto err_sysfs_unreg;
 	bcm43xx_periodic_tasks_setup(bcm);
+	/* force initial LO calibration */
+	phy->lo_control->txctl2 = 0xFFFF;

 	/*FIXME: This should be handled by softmac instead. */
 	schedule_delayed_work(&bcm->softmac->associnfo.work, 0);
@@ -3763,7 +3766,6 @@ static int bcm43xx_read_phyinfo(struct b
 		phy->lo_control = kzalloc(sizeof(*(phy->lo_control)), GFP_KERNEL);
 		if (!phy->lo_control)
 			return -ENOMEM;
-		phy->lo_control->txctl2 = 0xFFFF;//FIXME this is the wrong place
 	}

 	return 0;

----

  reply	other threads:[~2007-02-04 17:42 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <45B92488.6090908@lwfinger.net>
2007-01-25 21:46 ` Larry Finger
2007-01-25 23:30   ` roucaries bastien
2007-01-26 15:55     ` Larry Finger
2007-01-29 11:58       ` Pavel Machek
2007-01-29 12:55         ` roucaries bastien
2007-01-29 14:04           ` Matthew Garrett
2007-01-29 15:43             ` Larry Finger
2007-02-04 17:07               ` roucaries bastien
2007-02-04 17:42                 ` Larry Finger [this message]
2007-02-05  1:10                   ` Rafael J. Wysocki
2007-02-05  3:19                     ` Larry Finger
2007-01-25 19:18 roucaries bastien

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=45C61B09.7010102@lwfinger.net \
    --to=larry.finger@lwfinger.net \
    --cc=Bcm43xx-dev@lists.berlios.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mjg59@srcf.ucam.org \
    --cc=pavel@ucw.cz \
    --cc=roucaries.bastien@gmail.com \
    --subject='Re: Bcm43xx oops after suspend to disk' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).