LKML Archive on lore.kernel.org
 help / color / Atom feed
From: Ian Molton <spyro@f2s.com>
To: "Ahmed S. Darwish" <darwish.07@gmail.com>
Cc: kernel@wantstofly.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2.6.20] arch ARM: Use ARRAY_SIZE macro when appropriate
Date: Mon, 05 Feb 2007 09:24:10 +0000
Message-ID: <45C6F7BA.5050700@f2s.com> (raw)
In-Reply-To: <20070205024357.GP18118@Ahmed>

Ahmed S. Darwish wrote:
> Hi all,
> 
> A patch to use ARRAY_SIZE macro already defined in linux/kernel.h

Looks good. I can only speak for arm26 though, however trivial this is.

Signed-off-by: Ahmed S. Darwish <darwish.07@gmail.com>
Acked-by: Ian Molton <spyro@f2s.com

> ---
> Patch isn't compile checked cause I have no ARM machine at hand.
> Thanks,


diff --git a/arch/arm/kernel/ecard.c b/arch/arm/kernel/ecard.c
index 71257e3..f1c0fb9 100644
--- a/arch/arm/kernel/ecard.c
+++ b/arch/arm/kernel/ecard.c
@@ -1009,7 +1009,7 @@ ecard_probe(int slot, card_type_t type)
  		ec->fiqmask = 4;
  	}

-	for (i = 0; i < sizeof(blacklist) / sizeof(*blacklist); i++)
+	for (i = 0; i < ARRAY_SIZE(blacklist); i++)
  		if (blacklist[i].manufacturer == ec->cid.manufacturer &&
  		    blacklist[i].product == ec->cid.product) {
  			ec->card_desc = blacklist[i].type;
diff --git a/arch/arm26/kernel/ecard.c b/arch/arm26/kernel/ecard.c
index 9dbc172..e2bcefc 100644
--- a/arch/arm26/kernel/ecard.c
+++ b/arch/arm26/kernel/ecard.c
@@ -665,7 +665,7 @@ ecard_probe(int slot, card_type_t type)
  		ec->fiqmask = 4;
  	}

-	for (i = 0; i < sizeof(blacklist) / sizeof(*blacklist); i++)
+	for (i = 0; i < ARRAY_SIZE(blacklist); i++)
  		if (blacklist[i].manufacturer == ec->cid.manufacturer &&
  		    blacklist[i].product == ec->cid.product) {
  			ec->card_desc = blacklist[i].type;



      reply index

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-02-05  2:39 [PATCH 00] A series of patches to use ARRAY_SIZE macro under arch/ Ahmed S. Darwish
2007-02-05  2:40 ` [PATCH 2.6.20] arch CRIS: user ARRAY_SIZE macro when appropriate Ahmed S. Darwish
2007-02-05  2:41 ` [PATCH 2.6.20] arch AVR32: Use " Ahmed S. Darwish
2007-02-05  8:19   ` Haavard Skinnemoen
2007-02-05  2:41 ` [PATCH 2.6.20] arch M68KNOMMU: user " Ahmed S. Darwish
2007-02-05  5:40   ` Greg Ungerer
2007-02-05  2:42 ` [PATCH 2.6.20] arch MIPS: " Ahmed S. Darwish
2007-02-05 18:28   ` Ralf Baechle
2007-02-05  2:42 ` [PATCH 2.6.20] arch V850: " Ahmed S. Darwish
2007-02-05  2:42 ` [PATCH 2.6.20] arch PowerPC: " Ahmed S. Darwish
2007-02-05  2:43 ` [PATCH 2.6.20] arch PPC: " Ahmed S. Darwish
2007-02-05  2:43 ` [PATCH 2.6.20] arch M68K: " Ahmed S. Darwish
2007-02-05 20:15   ` Geert Uytterhoeven
2007-02-05  2:43 ` [PATCH 2.6.20] arch ARM: Use " Ahmed S. Darwish
2007-02-05  9:24   ` Ian Molton [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=45C6F7BA.5050700@f2s.com \
    --to=spyro@f2s.com \
    --cc=darwish.07@gmail.com \
    --cc=kernel@wantstofly.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

LKML Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lkml.kernel.org/lkml/0 lkml/git/0.git
	git clone --mirror https://lkml.kernel.org/lkml/1 lkml/git/1.git
	git clone --mirror https://lkml.kernel.org/lkml/2 lkml/git/2.git
	git clone --mirror https://lkml.kernel.org/lkml/3 lkml/git/3.git
	git clone --mirror https://lkml.kernel.org/lkml/4 lkml/git/4.git
	git clone --mirror https://lkml.kernel.org/lkml/5 lkml/git/5.git
	git clone --mirror https://lkml.kernel.org/lkml/6 lkml/git/6.git
	git clone --mirror https://lkml.kernel.org/lkml/7 lkml/git/7.git
	git clone --mirror https://lkml.kernel.org/lkml/8 lkml/git/8.git
	git clone --mirror https://lkml.kernel.org/lkml/9 lkml/git/9.git
	git clone --mirror https://lkml.kernel.org/lkml/10 lkml/git/10.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 lkml lkml/ https://lkml.kernel.org/lkml \
		linux-kernel@vger.kernel.org
	public-inbox-index lkml

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-kernel


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git