LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Auke Kok <auke-jan.h.kok@intel.com>
To: "Ahmed S. Darwish" <darwish.07@gmail.com>
Cc: cramerj@intel.com, john.ronciak@intel.com,
	linux-kernel@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH 2.6.20] e1000: Use ARRAY_SIZE macro when appropriate
Date: Tue, 06 Feb 2007 09:16:56 -0800	[thread overview]
Message-ID: <45C8B808.3080908@intel.com> (raw)
In-Reply-To: <20070205165546.GE3896@Ahmed>

Ahmed S. Darwish wrote:
> Hi,
> 
> A patch to use ARRAY_SIZE macro already defined in kernel.h.
> 
> Signed-off-by: Ahmed S. Darwish <darwish.07@gmail.com>

Acked-by: Auke Kok <auke-jan.h.kok@intel.com>

Cheers,

Auke

> ---
> Patch is compile tested.
> 
> diff --git a/drivers/net/e1000/e1000_ethtool.c b/drivers/net/e1000/e1000_ethtool.c
> index fb96c87..d21706e 100644
> --- a/drivers/net/e1000/e1000_ethtool.c
> +++ b/drivers/net/e1000/e1000_ethtool.c
> @@ -746,7 +746,7 @@ err_setup:
>  	uint32_t pat, value;                                                   \
>  	uint32_t test[] =                                                      \
>  		{0x5A5A5A5A, 0xA5A5A5A5, 0x00000000, 0xFFFFFFFF};              \
> -	for (pat = 0; pat < sizeof(test)/sizeof(test[0]); pat++) {              \
> +	for (pat = 0; pat < ARRAY_SIZE(test); pat++) {              \
>  		E1000_WRITE_REG(&adapter->hw, R, (test[pat] & W));             \
>  		value = E1000_READ_REG(&adapter->hw, R);                       \
>  		if (value != (test[pat] & W & M)) {                             \
> 

  reply	other threads:[~2007-02-06 17:17 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-02-05 16:54 [PATCH 00] A series of patches to use ARRAY_SIZE in `net' drivers Ahmed S. Darwish
2007-02-05 16:55 ` [PATCH 2.6.20] e1000: Use ARRAY_SIZE macro when appropriate Ahmed S. Darwish
2007-02-06 17:16   ` Auke Kok [this message]
2007-02-05 16:56 ` [PATCH 2.6.20] ipw2100: " Ahmed S. Darwish
2007-02-05 16:56 ` [PATCH 01/02] misc-net-drivers: " Ahmed S. Darwish
2007-02-05 16:57   ` [PATCH 02/02] " Ahmed S. Darwish
2007-02-05 16:58 ` [PATCH 2.6.20] misc-wireless: " Ahmed S. Darwish
2007-02-05 16:58 ` [PATCH 2.6.20] hostap: " Ahmed S. Darwish
2007-02-05 16:59 ` [PATCH 2.6.20] ibm_emac: " Ahmed S. Darwish
2007-02-05 20:22   ` Alexey Dobriyan
2007-02-06  9:12     ` Ahmed S. Darwish
2007-02-05 16:59 ` [PATCH 2.6.20] ixgb: " Ahmed S. Darwish
2007-02-05 20:18   ` Alexey Dobriyan
2007-02-05 20:31     ` Auke Kok
2007-02-06 10:00       ` Ahmed S. Darwish
2007-02-06 16:48         ` Auke Kok
2007-02-05 17:00 ` [PATCH 2.6.20] wavelan: " Ahmed S. Darwish
2007-02-05 20:17   ` Alexey Dobriyan
2007-02-06  9:34     ` Ahmed S. Darwish

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=45C8B808.3080908@intel.com \
    --to=auke-jan.h.kok@intel.com \
    --cc=cramerj@intel.com \
    --cc=darwish.07@gmail.com \
    --cc=john.ronciak@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --subject='Re: [PATCH 2.6.20] e1000: Use ARRAY_SIZE macro when appropriate' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
on how to clone and mirror all data and code used for this inbox