LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Chuck Ebbert <cebbert@redhat.com>
To: Randy Dunlap <randy.dunlap@oracle.com>
Cc: linux-kernel <linux-kernel@vger.kernel.org>,
	linux-scsi@vger.kernel.org, jejb <james.bottomley@steeleye.com>
Subject: Re: [patch] Re: SCSI logging sucks
Date: Fri, 09 Feb 2007 17:45:39 -0500	[thread overview]
Message-ID: <45CCF993.1030501@redhat.com> (raw)
In-Reply-To: <20070207153530.70412bc3.randy.dunlap@oracle.com>

Randy Dunlap wrote:
> Patch for Documentation/kernel-parameters.txt is below.
> Want more/different?
>
>
> Is this part of drivers/scsi/Kconfig correct??
>
> """
> config SCSI_LOGGING
> 	bool "SCSI logging facility"
> 	depends on SCSI
> 	---help---
> 	  This turns on a logging facility that can be used to debug a number
> 	  of SCSI related problems.
>
> 	  If you say Y here, no logging output will appear by default, but you
> 	  can enable logging by saying Y to "/proc file system support" and
> 	  "Sysctl support" below and executing the command
>
> 	  echo "scsi log token [level]" > /proc/scsi/scsi
>
> 	  at boot time after the /proc file system has been mounted.
>
> 	  There are a number of things that can be used for 'token' (you can
> 	  find them in the source: <file:drivers/scsi/scsi.c>), and this
> 	  allows you to select the types of information you want, and the
> 	  level allows you to select the level of verbosity.
> """
>
>   
I have no clue whether that works, but looking at scsi.c it would
seem it doesn't.  I only see add-single-device and remove-single-device
in there.
> From: Randy Dunlap <randy.dunlap@oracle.com>
>
> Minor corrections and additions to 'scsi_logging_level', as pointed out
> by Chuck Ebbert.
>
> Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
> ---
>  Documentation/kernel-parameters.txt |    5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
>
> --- linux-2620-work.orig/Documentation/kernel-parameters.txt
> +++ linux-2620-work/Documentation/kernel-parameters.txt
> @@ -1444,7 +1444,10 @@ and is between 256 and 4096 characters. 
>  			Format: <vendor>:<model>:<flags>
>  			(flags are integer value)
>  
> -	scsi_logging=	[SCSI]
> +	scsi_logging_level=	[SCSI] a bit mask of logging levels
> +			See drivers/scsi/scsi_logging.h for bits.  Also
> +			settable via sysctl at dev.scsi.logging_level
> +			(/proc/sys/dev/scsi/logging_level).
>  
>  	scsi_mod.scan=	[SCSI] sync (default) scans SCSI busses as they are
>  			discovered.  async scans them in kernel threads,
>   

Patch looks good. The script from IBM looks even better.


      parent reply	other threads:[~2007-02-09 22:44 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-02-07 17:06 Chuck Ebbert
2007-02-07 23:35 ` [patch] " Randy Dunlap
2007-02-08  0:20   ` Martin K. Petersen
2007-02-08  7:21     ` Volker Sameske
2007-02-09 22:45   ` Chuck Ebbert [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=45CCF993.1030501@redhat.com \
    --to=cebbert@redhat.com \
    --cc=james.bottomley@steeleye.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=randy.dunlap@oracle.com \
    --subject='Re: [patch] Re: SCSI logging sucks' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).