LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Alexey Starikovskiy <alexey.y.starikovskiy@linux.intel.com>
To: Len Brown <lenb@kernel.org>
Cc: Jens Axboe <jens.axboe@oracle.com>,
	linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: current git breaks resume
Date: Sun, 11 Feb 2007 17:34:26 +0300	[thread overview]
Message-ID: <45CF2972.40902@linux.intel.com> (raw)
In-Reply-To: <200702110002.38328.lenb@kernel.org>

[-- Attachment #1: Type: text/plain, Size: 677 bytes --]

Len Brown wrote:
> On Friday 09 February 2007 14:03, Jens Axboe wrote:
>   
>> Hi,
>>
>> Unfortunately I'm a little short on time as I'll be travelling tomorrow,
>> but of course preparing a new kernel for the laptop is something you
>> want to do right before leaving. So I discovered that the current (well
>> as of yesterday, HEAD is 5986a2ec35836a878350c54af4bd91b1de6abc59)
>> doesn't resume on my x60. 2.6.20 works fine, so something broke since
>> then.
>>     
>
> resume from RAM, or resume from disk?
>
>   
Len,
resume from RAM is still broken by "Disable all wakeup GPEs". My 
previous patch for T43 does not help, only attached one helps (revert 
original patch).

[-- Attachment #2: fix-disable_all_wake_gpes.patch --]
[-- Type: text/plain, Size: 1049 bytes --]

Disable wake GPEs only once.

From: Alexey Starikovskiy <alexey.y.starikovskiy@linux.intel.com>


---

 drivers/acpi/events/evgpe.c |   11 -----------
 1 files changed, 0 insertions(+), 11 deletions(-)

diff --git a/drivers/acpi/events/evgpe.c b/drivers/acpi/events/evgpe.c
index dfac3ec..635ba44 100644
--- a/drivers/acpi/events/evgpe.c
+++ b/drivers/acpi/events/evgpe.c
@@ -636,17 +636,6 @@ acpi_ev_gpe_dispatch(struct acpi_gpe_eve
 		}
 	}
 
-	if (!acpi_gbl_system_awake_and_running) {
-		/*
-		 * We just woke up because of a wake GPE. Disable any further GPEs
-		 * until we are fully up and running (Only wake GPEs should be enabled
-		 * at this time, but we just brute-force disable them all.)
-		 * 1) We must disable this particular wake GPE so it won't fire again
-		 * 2) We want to disable all wake GPEs, since we are now awake
-		 */
-		(void)acpi_hw_disable_all_gpes();
-	}
-
 	/*
 	 * Dispatch the GPE to either an installed handler, or the control method
 	 * associated with this GPE (_Lxx or _Exx). If a handler exists, we invoke

  reply	other threads:[~2007-02-11 14:34 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-02-09 19:03 Jens Axboe
2007-02-10  9:49 ` Rafael J. Wysocki
2007-02-10 11:24   ` Jens Axboe
2007-02-10 11:50     ` Jens Axboe
2007-02-10 11:57       ` Rafael J. Wysocki
2007-02-11  3:28         ` Jens Axboe
2007-02-11  5:02 ` Len Brown
2007-02-11 14:34   ` Alexey Starikovskiy [this message]
2007-02-11 16:53   ` Jens Axboe
2007-02-11 17:31     ` Alexey Starikovskiy
2007-02-11 17:36       ` Jens Axboe
2007-02-11 17:56         ` Jens Axboe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=45CF2972.40902@linux.intel.com \
    --to=alexey.y.starikovskiy@linux.intel.com \
    --cc=jens.axboe@oracle.com \
    --cc=lenb@kernel.org \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --subject='Re: current git breaks resume' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).