LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Tejun Heo <htejun@gmail.com>
To: Joel Soete <soete.joel@scarlet.be>
Cc: Luming Yu <luming.yu@gmail.com>, Alan Cox <alan@redhat.com>,
	Ioan Ionita <opslynx@gmail.com>, Alan <alan@lxorguk.ukuu.org.uk>,
	linux-kernel@vger.kernel.org, jgarzik@pobox.com
Subject: Re: 2.6.20-rc6 libata PATA ATAPI CDROM is not working
Date: Sun, 11 Feb 2007 16:58:57 -0800	[thread overview]
Message-ID: <45CFBBD1.5090703@gmail.com> (raw)
In-Reply-To: <45BB64F1.1000105@scarlet.be>

[-- Attachment #1: Type: text/plain, Size: 64 bytes --]

Please test the attached patch over 2.6.20.

Thanks.

-- 
tejun

[-- Attachment #2: clear-TF-before-IDENTIFY.patch --]
[-- Type: text/x-patch, Size: 780 bytes --]

diff --git a/drivers/ata/libata-core.c b/drivers/ata/libata-core.c
index 667acd2..d6fcf0a 100644
--- a/drivers/ata/libata-core.c
+++ b/drivers/ata/libata-core.c
@@ -1478,7 +1478,16 @@ int ata_dev_read_id(struct ata_device *dev, unsigned int *p_class,
 	}
 
 	tf.protocol = ATA_PROT_PIO;
-	tf.flags |= ATA_TFLAG_POLLING; /* for polling presence detection */
+
+	/* Some devices choke if TF registers contain garbage.  Make
+	 * sure those are properly initialized.
+	 */
+	tf.flags |= ATA_TFLAG_ISADDR | ATA_TFLAG_DEVICE;
+
+	/* Device presence detection is unreliable on some
+	 * controllers.  Always poll IDENTIFY if available.
+	 */
+	tf.flags |= ATA_TFLAG_POLLING;
 
 	err_mask = ata_exec_internal(dev, &tf, NULL, DMA_FROM_DEVICE,
 				     id, sizeof(id[0]) * ATA_ID_WORDS);

  reply	other threads:[~2007-02-12  6:45 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-11-16 23:22 2.6.19-rc5 libata PATA ATAPI CDROM SiS 5513 NOT WORKING Ioan Ionita
2006-11-16 23:50 ` Alan
2006-11-17  1:30   ` Ioan Ionita
2006-11-17  1:34     ` Ioan Ionita
2006-11-17 10:05       ` Alan Cox
2006-11-17 15:44         ` Ioan Ionita
2006-12-27 14:44         ` Joel Soete
2006-12-28 21:50           ` Joel Soete
2007-01-03  4:31             ` Tejun Heo
2007-01-03 17:19               ` Joel Soete
2007-01-27 13:22                 ` 2.6.20-rc6 libata PATA ATAPI CDROM is not working Joel Soete
2007-01-27 14:10                   ` Luming Yu
2007-01-27 14:42                     ` Joel Soete
2007-02-12  0:58                       ` Tejun Heo [this message]
2007-02-12 20:42                         ` Joel Soete
2007-02-13 17:35                           ` Joel Soete
2007-02-13 18:15                             ` Bartlomiej Zolnierkiewicz
2007-02-13 18:34                               ` Alan
2007-02-17 12:07                               ` Joel Soete
2007-02-17 12:52                                 ` Bartlomiej Zolnierkiewicz
2007-02-13 18:22                             ` Tejun Heo
2007-02-17 10:58                               ` Joel Soete
2007-02-20 11:21                                 ` Tejun Heo
2007-02-13 19:57                             ` Lennart Sorensen
2007-02-17 11:33                               ` Joel Soete
2007-02-17 14:59                                 ` Lennart Sorensen
2007-02-17 18:26                                   ` Joel Soete
2007-02-21  2:55                         ` Ioan Ionita
2007-02-20  7:40 Joel Soete

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=45CFBBD1.5090703@gmail.com \
    --to=htejun@gmail.com \
    --cc=alan@lxorguk.ukuu.org.uk \
    --cc=alan@redhat.com \
    --cc=jgarzik@pobox.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luming.yu@gmail.com \
    --cc=opslynx@gmail.com \
    --cc=soete.joel@scarlet.be \
    --subject='Re: 2.6.20-rc6 libata PATA ATAPI CDROM is not working' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).