LKML Archive on
help / color / mirror / Atom feed
From: "Jan Beulich" <>
To: "Christoph Hellwig" <>
Cc: <>,
	"Linux Kernel Mailing List" <>
Subject: Re: [IA64] swiotlb abstraction (e.g. for Xen)
Date: Mon, 12 Feb 2007 07:30:55 +0000	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

On Wed, Feb 07, 2007 at 09:32:54AM +0100, Christoph Hellwig wrote:
> On Wed, Feb 07, 2007 at 07:59:18AM +0000, Linux Kernel Mailing List wrote:
> >     [IA64] swiotlb abstraction (e.g. for Xen)
> >     
> >     Add abstraction so that the file can be used by environments other than IA64
> >     and EM64T, namely for Xen.
> Tony, this code is more than ugly, and even further not needed for anything
> we actually need.  Can you please revert it.
> Some comments below in case we need justification..
> If Jan actually had a goal with that except making the code utterly
> unreadable he should try again with small patches that are well
> explained and do one thing at a at time.  (And cane be reviewed an
> improved on if needed.

As the topic says - the goal is to support Xen. But yes, I was afraid someone would
claim this make the code look ugly. And no, I currently don't have ideas to address
any of your comments without breaking functionality on Xen...


  reply	other threads:[~2007-02-12  7:32 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <>
2007-02-07  8:32 ` Christoph Hellwig
2007-02-11  7:25   ` Christoph Hellwig
2007-02-12  7:30     ` Jan Beulich [this message]
2007-02-12  8:14       ` Arjan van de Ven
2007-02-12  8:56         ` Muli Ben-Yehuda
2007-02-12  8:58         ` Jan Beulich
2007-02-12 17:12       ` Christoph Hellwig
2007-02-13  7:27         ` Jan Beulich
2007-02-13  7:53           ` Arjan van de Ven

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \
    --subject='Re: [IA64] swiotlb abstraction (e.g. for Xen)' \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).