LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Tejun Heo <htejun@gmail.com>
To: Jean Delvare <jdelvare@suse.de>
Cc: Leopold Palomo Avellaneda <lepalom@wol.es>,
	linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org,
	Alan Cox <alan@lxorguk.ukuu.org.uk>,
	Jeff Garzik <jgarzik@pobox.com>
Subject: Re: Sata_via problems in a Vintage2-AE1
Date: Mon, 12 Feb 2007 01:47:47 -0800	[thread overview]
Message-ID: <45D037C3.3070306@gmail.com> (raw)
In-Reply-To: <200702121011.49818.jdelvare@suse.de>

Jean Delvare wrote:
> I've read the whole thread, the source code (quickly) and the patches to 
> ahci.c and sata_via.c, and here are some comments:
> 
> It looks like support for the VT8251 was added to the ahci driver in kernel 
> 2.6.18, and was then updated in 2.6.20. The code is different from the 
> patch Leopold is using with 2.6.16. As I am not an expert in this area, I 
> can't tell whether both versions are equivalent or not, but I'd guess so.

The differences between 2.6.16 and 2.6.20 in ahci are mostly things like 
detection fixes and hotplug handling fixes which shouldn't affect normal 
operations too much and irqpoll definitely won't fix the problem.

> On the other hand, I do not see VT8251 support in the sata_via driver in the 
> kernel, so I'm not surprised that it doesn't work properly for Leopold. But 
> again I am no expert in the area, so maybe the sata_via driver in the kernel 
> is supposed to work for VT8251-based systems. Jeff (cc'd) should know better.

vt8251 is an ahci controller so sata_via is irrelevant.

> I also see that there were many changes to these drivers post-2.6.20, so maybe 
> Leopold could give a try to Linus' latest kernel (2.6.20-git6 as I speak) and 
> see if there are any improvements.
> 
> As for the VIA IRQ quirks, the version we have in 2.6.20 does not handle the 
> VIA chips more recent than the VT8237A. If the VT8251 needs it, then we have 
> to add it. Alan?
> 
> *If* the VT8251 needs the VIA IRQ quirk, then the attached patch may help. 
> Leopold, can you give it a try?

This is where I have no clue.  :-)  Leopold, please test Jean's patch.

Thanks a lot.

-- 
tejun

  reply	other threads:[~2007-02-12  9:48 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-02-08 23:10 Leopold Palomo Avellaneda
2007-02-09  9:46 ` Tejun Heo
2007-02-09 17:13   ` Leopold Palomo Avellaneda
2007-02-09 20:09     ` Leopold Palomo Avellaneda
2007-02-10 14:45       ` Tejun Heo
2007-02-10 17:05         ` Leopold Palomo Avellaneda
2007-02-12  9:11         ` Jean Delvare
2007-02-12  9:47           ` Tejun Heo [this message]
2007-02-12 10:57           ` Leopold Palomo-Avellaneda
2007-02-12 16:23           ` Leopold Palomo-Avellaneda
2007-02-13 11:20             ` Jean Delvare
2007-02-13 16:11               ` Leopold Palomo-Avellaneda
2007-02-13 16:19                 ` Jean Delvare
2007-02-15 11:23                   ` Sata_via problems in a Vintage2-AE1: Resume Leopold Palomo-Avellaneda
2007-02-21 11:42                     ` Tejun Heo
2007-02-21 15:56                       ` Leopold Palomo-Avellaneda

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=45D037C3.3070306@gmail.com \
    --to=htejun@gmail.com \
    --cc=alan@lxorguk.ukuu.org.uk \
    --cc=jdelvare@suse.de \
    --cc=jgarzik@pobox.com \
    --cc=lepalom@wol.es \
    --cc=linux-ide@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --subject='Re: Sata_via problems in a Vintage2-AE1' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).