LKML Archive on
help / color / mirror / Atom feed
From: Tejun Heo <>
To: Pavel Machek <>
Cc: Robert Hancock <>,
	linux-kernel <>,
Subject: Re: pcim_enable_device BUGs for libata devices in 2.6.20-git6
Date: Tue, 13 Feb 2007 07:30:03 -0800	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

Hello, Pavel.

Pavel Machek wrote:
>> 1. Don't restore power state and re-enable PCI device on resume from 
>> freeze just as we don't do the opposite when freezing.
>> 2. Unconditionally disable and power down PCI device on suspend whether 
>> it's freeze or not.
>> #2 would be simpler but I'm a bit worried about it.  There might be 
>> controllers which choke after such sequence (save state, disable, power 
>> down, no actual power removal, power on, restore state, re-enable).
> I'd just go for #2.

I think I've been seeing too many weird ATA controller issues to be bold 
about this.  I'll chicken out and go for #1.  :-)

>> #1 can be easily done by taking a look at the current device power state 
>> (gendev->power.power_state).  The problem is that no one in 
>> suspend/resume path seems to be setting that variable except for
>> runtime 
> No, that variable is probably going to go away. If you want to
> remember that you are resuming from freeze, just store that info in
> private data structure.

I see.  Thanks.


      reply	other threads:[~2007-02-13 15:30 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-02-12  0:44 Robert Hancock
2007-02-12  9:11 ` Tejun Heo
2007-02-12 20:54   ` Pavel Machek
2007-02-13 15:30     ` Tejun Heo [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \
    --subject='Re: pcim_enable_device BUGs for libata devices in 2.6.20-git6' \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).