LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: "Jan Beulich" <jbeulich@novell.com>
To: "Alan" <alan@lxorguk.ukuu.org.uk>
Cc: <alan@redhat.com>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH, RFC] adjust legacy IDE resource setting
Date: Wed, 14 Feb 2007 15:46:49 +0000	[thread overview]
Message-ID: <45D33CF9.76E4.0078.0@novell.com> (raw)
In-Reply-To: <20070214154014.7fa76711@localhost.localdomain>

>>> Alan <alan@lxorguk.ukuu.org.uk> 14.02.07 16:40 >>>
>On Wed, 14 Feb 2007 15:05:24 +0000
>"Jan Beulich" <jbeulich@novell.com> wrote:
>
>> The change to force legacy mode IDE channels' resources to fixed
>> non-zero values confuses (at least some versions of) X, because the
>> values reported by the kernel and those readable from PCI config space
>> aren't consistent anymore. Therefore, this patch arranges for the
>> respective BARs to also get updated if possible.
>
>If X is getting confused fix X. Those BARs are *undefined* in legacy
>mode. The value in them is undefined, the results that end up there if
>you do write to them are undefined too. If X believes those BAR values
>blindly it'll do the wrong thing in some freaky cases.
>
>Which specific versions of X are problematic ?

The one I ran into problems with is reporting

X Window System Version 6.9.0
Release Date: 21 December 2005

(used in SLES10, the specific package version is xorg-x11-6.9.0-50.14)

>As to the implementation:
>	start and end as passed are the real I/O values so you don't need
>to mask them that I can see.

The masking is done primarily to (a) calculate the correct length (from a BAR's
perspective), as I don't want to write the BAR if its length doesn't match the
expectation, and (b) to properly report the new value in the printk.

>I've no fundamental problem with writing the BAR values back to avoid
>confusing some apparently broken X, but I'd like to know what X, what
>circumstances and that X is also getting fixed.

Of course I also opened a bug against X, as I too think it's doing something
wrong here.

Jan

  reply	other threads:[~2007-02-14 15:45 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-02-14 15:05 Jan Beulich
2007-02-14 15:40 ` Alan
2007-02-14 15:46   ` Jan Beulich [this message]
2007-02-14 16:09     ` Alan
2007-03-07 18:10       ` Petri Kaukasoina

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=45D33CF9.76E4.0078.0@novell.com \
    --to=jbeulich@novell.com \
    --cc=alan@lxorguk.ukuu.org.uk \
    --cc=alan@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --subject='Re: [PATCH, RFC] adjust legacy IDE resource setting' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).