LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Zachary Amsden <zach@vmware.com>
To: Alan <alan@lxorguk.ukuu.org.uk>
Cc: Rusty Russell <rusty@rustcorp.com.au>,
	Pavel Machek <pavel@ucw.cz>, Andi Kleen <ak@muc.de>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Andrew Morton <akpm@osdl.org>,
	Jeremy Fitzhardinge <jeremy@goop.org>,
	Chris Wright <chrisw@sous-sol.org>
Subject: Re: [PATCH 9/11] Panic delay fix
Date: Wed, 14 Feb 2007 13:53:08 -0800	[thread overview]
Message-ID: <45D384C4.2000306@vmware.com> (raw)
In-Reply-To: <20070214213423.4834941b@localhost.localdomain>

Alan wrote:
>> ???  I fail to see the code bloat and also the fast paths.  Which fast 
>> paths use udelay?
>>     
>
> IDE on several platforms has performance critical paths that use
> ndelay(400) or failing that udelay(1)

Ok, I buy that.  A 486DX / 33 Mhz processor takes 10 cycles to issue a 
CALL / RET pair.  This is about 300ns.  Is there an issue with being too 
early to issue I/O operations or too late?

If it is too early, then we have lost 10 cycles of processor time per 
udelay, which considering the antiquity of this piece of hardware, seems 
acceptable.

If it is too late, then there could be a real issue on older machines.  
But I fail to see how such careful timing can be done at this 
granularity on such hardware without well tweaked assembly code.  A 
suboptimal compile output could easily throw you off by just as much, 
sticking a little bit of arithmetic before and after the delay.

Zach

  reply	other threads:[~2007-02-14 21:53 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-02-06  3:53 Zachary Amsden
2007-02-06 12:27 ` Andi Kleen
2007-02-06 21:59   ` Zachary Amsden
2007-02-07 12:35     ` Pavel Machek
2007-02-07 20:36       ` Rusty Russell
2007-02-07 22:23         ` Zachary Amsden
2007-02-08 14:43         ` Dmitry Torokhov
2007-02-08 21:26           ` Zachary Amsden
2007-02-08 21:37             ` Dmitry Torokhov
2007-02-14 12:26         ` Pavel Machek
2007-02-14 19:47           ` Zachary Amsden
2007-02-14 12:52         ` Alan
2007-02-14 20:04           ` Zachary Amsden
2007-02-14 21:34             ` Alan
2007-02-14 21:53               ` Zachary Amsden [this message]
2007-02-15  0:33                 ` Alan
2007-02-15 10:17             ` Pavel Machek
2007-02-15 23:42               ` Zachary Amsden
2007-02-15 23:49                 ` Pavel Machek
2007-02-15 23:50                 ` Jeremy Fitzhardinge
2007-02-16  3:22                 ` Rusty Russell
2007-02-07 14:58     ` Dmitry Torokhov
2007-02-07 22:31       ` Zachary Amsden
2007-02-08  8:24         ` Andi Kleen
2007-02-08  9:08           ` Zachary Amsden
2007-02-08 13:33             ` Andi Kleen
2007-02-08 14:41               ` Dmitry Torokhov
2007-02-14 12:49             ` Alan
2007-02-14 22:51 ` Rusty Russell
2007-02-15  0:28   ` Alan
2007-02-15 13:35   ` Dmitry Torokhov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=45D384C4.2000306@vmware.com \
    --to=zach@vmware.com \
    --cc=ak@muc.de \
    --cc=akpm@osdl.org \
    --cc=alan@lxorguk.ukuu.org.uk \
    --cc=chrisw@sous-sol.org \
    --cc=jeremy@goop.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pavel@ucw.cz \
    --cc=rusty@rustcorp.com.au \
    --subject='Re: [PATCH 9/11] Panic delay fix' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).