LKML Archive on
help / color / mirror / Atom feed
From: Corey Minyard <>
To: Andrew Morton <>
Cc: Paul Mackerras <>,
	Linux Kernel <>
Subject: Re: [patch 4/4] ipmi: add new IPMI nmi watchdog handling
Date: Thu, 15 Feb 2007 09:49:15 -0600	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

Andrew Morton wrote:
> On Thu, 15 Feb 2007 15:05:56 +1100 Paul Mackerras <> wrote:
>> Andrew Morton writes:
>>> This is all fairly unpleasant.
>>> What architecture is preventing us from using DIE_NMI_POST on all
>>> architectures which support ipmi?  ia64?
>>> It would be better to simply require that all ipmi-using architectures
>>> implement notify_die(DIE_NMI_POST, ...).
>> We're starting to see IPMI creeping on powerpc as well, and we don't
>> have an NMI.
PowerPC could have an NMI, at least on many of the processors, if 
manufacturers would wire in the MCP line and use it as an NMI.
> Sure, but you could implement the registration function.  I mean, you
> _would_ call the NMI callback if you could, right ;)
> As it stands, this change is pretty gruesome...
Yes, it's certainly not ideal.  Most architectures do not have 
asm/kdebug.h, which was the reason for CONFIG_HAVE_STANDARD_NOTIFY_DIE.  
I know there are IPMI implementations on x86, ia64, ARM, MIPS, and PowerPC.

So I see the following options besides what's already there:

1) add asm/kdebug.h and DIE_NMI_POST to everything that might have an 
IPMI implementation.
2) use CONFIG_X86 to tell if NMI will work, since that's the only thing 
it will work on at the present.

I don't have any way to know how different systems have implemented that 
feature, so I can't actually implement it for the various architectures 
(plus I don't have any of those boards).  So maybe #2 is the best?


  reply	other threads:[~2007-02-15 15:49 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-02-14 20:12 Corey Minyard
2007-02-15  3:57 ` Andrew Morton
2007-02-15  4:05   ` Paul Mackerras
2007-02-15  4:16     ` Andrew Morton
2007-02-15 15:49       ` Corey Minyard [this message]
2007-02-15 22:21         ` Andrew Morton
2007-02-16  0:26           ` Corey Minyard
2007-02-19 20:14           ` Corey Minyard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \
    --subject='Re: [patch 4/4] ipmi: add new IPMI nmi watchdog handling' \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).