LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH] No need to use -traditional for processing asm in i386/kernel/
@ 2007-02-15 21:19 Jeremy Fitzhardinge
  2007-02-15 22:44 ` Sam Ravnborg
  0 siblings, 1 reply; 3+ messages in thread
From: Jeremy Fitzhardinge @ 2007-02-15 21:19 UTC (permalink / raw)
  To: Andi Kleen; +Cc: Linux Kernel Mailing List

No need to use -traditional for processing asm in i386/kernel/

Signed-off-by: Jeremy Fitzhardinge <jeremy@xensource.com>

diff -r 2d901729b314 arch/i386/kernel/Makefile
--- a/arch/i386/kernel/Makefile	Thu Feb 15 13:00:50 2007 -0800
+++ b/arch/i386/kernel/Makefile	Thu Feb 15 13:10:49 2007 -0800
@@ -44,8 +44,6 @@ obj-$(CONFIG_PARAVIRT)		+= paravirt.o
 obj-$(CONFIG_PARAVIRT)		+= paravirt.o
 obj-y				+= pcspeaker.o
 
-EXTRA_AFLAGS   := -traditional
-
 obj-$(CONFIG_SCx200)		+= scx200.o
 
 # vsyscall.o contains the vsyscall DSO images as __initdata.
diff -r 2d901729b314 arch/i386/kernel/entry.S
--- a/arch/i386/kernel/entry.S	Thu Feb 15 13:00:50 2007 -0800
+++ b/arch/i386/kernel/entry.S	Thu Feb 15 13:10:49 2007 -0800
@@ -635,7 +635,7 @@ ENTRY(name)				\
 	SAVE_ALL;			\
 	TRACE_IRQS_OFF			\
 	movl %esp,%eax;			\
-	call smp_/**/name;		\
+	call smp_##name;		\
 	jmp ret_from_intr;		\
 	CFI_ENDPROC;			\
 ENDPROC(name)
diff -r 2d901729b314 include/asm-i386/percpu.h
--- a/include/asm-i386/percpu.h	Thu Feb 15 13:00:50 2007 -0800
+++ b/include/asm-i386/percpu.h	Thu Feb 15 13:10:49 2007 -0800
@@ -20,10 +20,10 @@
 #ifdef CONFIG_SMP
 #define PER_CPU(var, cpu) \
 	movl __per_cpu_offset(,cpu,4), cpu;	\
-	addl $per_cpu__/**/var, cpu;
+	addl $per_cpu__##var, cpu;
 #else /* ! SMP */
 #define PER_CPU(var, cpu) \
-	movl $per_cpu__/**/var, cpu;
+	movl $per_cpu__##var, cpu;
 #endif	/* SMP */
 
 #endif /* !__ASSEMBLY__ */



^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] No need to use -traditional for processing asm in i386/kernel/
  2007-02-15 21:19 [PATCH] No need to use -traditional for processing asm in i386/kernel/ Jeremy Fitzhardinge
@ 2007-02-15 22:44 ` Sam Ravnborg
  2007-02-15 23:48   ` Jeremy Fitzhardinge
  0 siblings, 1 reply; 3+ messages in thread
From: Sam Ravnborg @ 2007-02-15 22:44 UTC (permalink / raw)
  To: Jeremy Fitzhardinge; +Cc: Andi Kleen, Linux Kernel Mailing List

On Thu, Feb 15, 2007 at 01:19:12PM -0800, Jeremy Fitzhardinge wrote:
> No need to use -traditional for processing asm in i386/kernel/
> 
> Signed-off-by: Jeremy Fitzhardinge <jeremy@xensource.com>

Any possibility that you could 'fix' the three remaining
uses of -traditional in i386?

	Sam

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] No need to use -traditional for processing asm in i386/kernel/
  2007-02-15 22:44 ` Sam Ravnborg
@ 2007-02-15 23:48   ` Jeremy Fitzhardinge
  0 siblings, 0 replies; 3+ messages in thread
From: Jeremy Fitzhardinge @ 2007-02-15 23:48 UTC (permalink / raw)
  To: Sam Ravnborg; +Cc: Andi Kleen, Linux Kernel Mailing List

Sam Ravnborg wrote:
> On Thu, Feb 15, 2007 at 01:19:12PM -0800, Jeremy Fitzhardinge wrote:
>   
>> No need to use -traditional for processing asm in i386/kernel/
>>
>> Signed-off-by: Jeremy Fitzhardinge <jeremy@xensource.com>
>>     
>
> Any possibility that you could 'fix' the three remaining
> uses of -traditional in i386?
>   

Sure.  Looks like they're not even really used.

    J

--

No need to use -traditional for processing asm in arch/i386/

Signed-off-by: Jeremy Fitzhardinge <jeremy@xensource.com>

diff -r 9e6791a29740 arch/i386/boot/Makefile
--- a/arch/i386/boot/Makefile	Thu Feb 15 11:57:29 2007 -0800
+++ b/arch/i386/boot/Makefile	Thu Feb 15 15:45:46 2007 -0800
@@ -36,9 +36,9 @@ HOSTCFLAGS_build.o := $(LINUXINCLUDE)
 # ---------------------------------------------------------------------------
 
 $(obj)/zImage:  IMAGE_OFFSET := 0x1000
-$(obj)/zImage:  EXTRA_AFLAGS := -traditional $(SVGA_MODE) $(RAMDISK)
+$(obj)/zImage:  EXTRA_AFLAGS := $(SVGA_MODE) $(RAMDISK)
 $(obj)/bzImage: IMAGE_OFFSET := 0x100000
-$(obj)/bzImage: EXTRA_AFLAGS := -traditional $(SVGA_MODE) $(RAMDISK) -D__BIG_KERNEL__
+$(obj)/bzImage: EXTRA_AFLAGS := $(SVGA_MODE) $(RAMDISK) -D__BIG_KERNEL__
 $(obj)/bzImage: BUILDFLAGS   := -b
 
 quiet_cmd_image = BUILD   $@
diff -r 9e6791a29740 arch/i386/boot/compressed/Makefile
--- a/arch/i386/boot/compressed/Makefile	Thu Feb 15 11:57:29 2007 -0800
+++ b/arch/i386/boot/compressed/Makefile	Thu Feb 15 15:45:46 2007 -0800
@@ -6,7 +6,6 @@
 
 targets		:= vmlinux vmlinux.bin vmlinux.bin.gz head.o misc.o piggy.o \
 			vmlinux.bin.all vmlinux.relocs
-EXTRA_AFLAGS	:= -traditional
 
 LDFLAGS_vmlinux := -T
 CFLAGS_misc.o += -fPIC
diff -r 9e6791a29740 arch/i386/kernel/Makefile
--- a/arch/i386/kernel/Makefile	Thu Feb 15 11:57:29 2007 -0800
+++ b/arch/i386/kernel/Makefile	Thu Feb 15 15:45:46 2007 -0800
@@ -44,8 +44,6 @@ obj-$(CONFIG_PARAVIRT)		+= paravirt.o
 obj-$(CONFIG_PARAVIRT)		+= paravirt.o
 obj-y				+= pcspeaker.o
 
-EXTRA_AFLAGS   := -traditional
-
 obj-$(CONFIG_SCx200)		+= scx200.o
 
 # vsyscall.o contains the vsyscall DSO images as __initdata.
diff -r 9e6791a29740 arch/i386/kernel/entry.S
--- a/arch/i386/kernel/entry.S	Thu Feb 15 11:57:29 2007 -0800
+++ b/arch/i386/kernel/entry.S	Thu Feb 15 15:45:46 2007 -0800
@@ -635,7 +635,7 @@ ENTRY(name)				\
 	SAVE_ALL;			\
 	TRACE_IRQS_OFF			\
 	movl %esp,%eax;			\
-	call smp_/**/name;		\
+	call smp_##name;		\
 	jmp ret_from_intr;		\
 	CFI_ENDPROC;			\
 ENDPROC(name)
diff -r 9e6791a29740 include/asm-i386/percpu.h
--- a/include/asm-i386/percpu.h	Thu Feb 15 11:57:29 2007 -0800
+++ b/include/asm-i386/percpu.h	Thu Feb 15 15:45:46 2007 -0800
@@ -20,10 +20,10 @@
 #ifdef CONFIG_SMP
 #define PER_CPU(var, cpu) \
 	movl __per_cpu_offset(,cpu,4), cpu;	\
-	addl $per_cpu__/**/var, cpu;
+	addl $per_cpu__##var, cpu;
 #else /* ! SMP */
 #define PER_CPU(var, cpu) \
-	movl $per_cpu__/**/var, cpu;
+	movl $per_cpu__##var, cpu;
 #endif	/* SMP */
 
 #endif /* !__ASSEMBLY__ */


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2007-02-15 23:48 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2007-02-15 21:19 [PATCH] No need to use -traditional for processing asm in i386/kernel/ Jeremy Fitzhardinge
2007-02-15 22:44 ` Sam Ravnborg
2007-02-15 23:48   ` Jeremy Fitzhardinge

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).