LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Jeff Garzik <jeff@garzik.org>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	linux-ide@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>,
	Alan Cox <alan@lxorguk.ukuu.org.uk>,
	"Luck, Tony" <tony.luck@intel.com>,
	Zhang Yanmin <yanmin.zhang@intel.com>
Subject: Re: [git patches] libata updates (mostly fixes)
Date: Thu, 15 Feb 2007 21:09:12 -0500	[thread overview]
Message-ID: <45D51248.5070408@garzik.org> (raw)
In-Reply-To: <Pine.LNX.4.64.0702151546130.20368@woody.linux-foundation.org>

Linus Torvalds wrote:
> 
> On Thu, 15 Feb 2007, Jeff Garzik wrote:
>> diff --git a/arch/ia64/Kconfig b/arch/ia64/Kconfig
>> index db185f3..d51f0f1 100644
>> --- a/arch/ia64/Kconfig
>> +++ b/arch/ia64/Kconfig
>> @@ -22,6 +22,7 @@ config IA64
>>  
>>  config 64BIT
>>  	bool
>> +	select ATA_NONSTANDARD if ATA
>>  	default y
> 
> Ok, this is just _strange_.

Agreed.


> Tying ATA_NONSTANDARD into ia64 by tying it to the 64BIT config variable 
> may work (well, I _assume_ it does), but it's just psychedelic.

AFAICT it's an attempt to do an unconditional 'select'.  I'm /not/ 
disputing its psychedilic properties, certainly, just figured that was 
the way that IA64 arch folks did stuff like this.


> How about adding a separate config entry like
> 
> 	config IA64_ATA
> 		bool
> 		depends on ATA
> 		select ATA_NONSTANDARD
> 		default y
> 
> which kind of makes sense when you squint just the right way..

Either way, that seems sane to me.  I'd love to have some IA64 folks to 
comment though.

	Jeff



  parent reply	other threads:[~2007-02-16  2:09 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-02-15 23:34 Jeff Garzik
2007-02-15 23:43 ` Jeff Garzik
2007-02-21 11:25   ` [PATCH] libata: test major version in ata_id_is_sata() Tejun Heo
2007-02-23 10:37     ` Jeff Garzik
2007-02-15 23:48 ` [git patches] libata updates (mostly fixes) Linus Torvalds
2007-02-15 23:51   ` Linus Torvalds
2007-02-16  2:09   ` Jeff Garzik [this message]
2007-02-16 12:03   ` Adrian Bunk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=45D51248.5070408@garzik.org \
    --to=jeff@garzik.org \
    --cc=akpm@linux-foundation.org \
    --cc=alan@lxorguk.ukuu.org.uk \
    --cc=linux-ide@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tony.luck@intel.com \
    --cc=torvalds@linux-foundation.org \
    --cc=yanmin.zhang@intel.com \
    --subject='Re: [git patches] libata updates (mostly fixes)' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).