LKML Archive on
help / color / mirror / Atom feed
From: Andres Salomon <>
To: Dmitry Torokhov <>
Cc: Andrew Morton <>,
Subject: Re: [patch 1/3] Input: psmouse - create PS/2 protocol options for Kconfig
Date: Fri, 16 Feb 2007 00:34:24 -0500	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

Dmitry Torokhov wrote:
> On Thursday 15 February 2007 20:30, Andrew Morton wrote:
>> On Thu, 15 Feb 2007 19:55:29 -0500
>> Andres Salomon <> wrote:
>> Perhaps a nicer implementation would be to have a separate .c file for each
>> variant.
> Having completely separate sub-drivers is very hard because of very delicate
> PS/2 protocol probing....
> What do you think about patch below? It somewhat reduces #ifdef clutter in main
> module moving it in .h files...

Normally, I'm a fan of that sort of thing.  However, in this case, I
think it makes sense to have the #ifdefs right in the probe function; at
least for me, it makes it easier to understand what's going on.  The
synaptics stuff is especially tricky; with a cursory glance over the
code, one might assume that all the synaptics functions disappear when
CONFIG_MOUSE_PS2_SYNAPTICS is unset.  However, if the #ifdef's are in
the probe function, it's pretty clear that some synaptics functions
still get called even when CONFIG_MOUSE_PS2_SYNAPTICS is unset.

Just my opinion, anyways.

  reply	other threads:[~2007-02-16  5:34 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-02-15 10:08 Andres Salomon
2007-02-16  0:45 ` Andrew Morton
2007-02-16  0:55   ` Andres Salomon
2007-02-16  1:30     ` Andrew Morton
2007-02-16  5:28       ` Dmitry Torokhov
2007-02-16  5:34         ` Andres Salomon [this message]
2007-02-16 15:42           ` Dmitry Torokhov
2007-02-16 18:02             ` Andres Salomon
2007-03-09 11:02             ` Andres Salomon
2007-03-09 14:23               ` Dmitry Torokhov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \
    --subject='Re: [patch 1/3] Input: psmouse - create PS/2 protocol options for Kconfig' \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).