LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: "Chris Friesen" <cfriesen@nortel.com>
To: linux-kernel@vger.kernel.org
Subject: misleading comment in __oom_kill_task()?
Date: Fri, 16 Feb 2007 13:03:58 -0600	[thread overview]
Message-ID: <45D6001E.1020605@nortel.com> (raw)


Towards the end of __oom_kill_task() we see the following comment/code:

	/*
	 * We give our sacrificial lamb high priority and access to
	 * all the memory it needs. That way it should be able to
	 * exit() and clear out its resources quickly...
	 */
	p->time_slice = HZ;
	set_tsk_thread_flag(p, TIF_MEMDIE);

	force_sig(SIGKILL, p);

I see it getting a large timeslice and access to memory, but I don't 
actually see the priority getting bumped at all.  It appears the comment 
is inaccurate.

Should the process actually get its priority bumped up as well so that 
it can process its own death faster?  The reason I ask is that we're 
seeing some oom-killed processes taking a very long time (multiple 
seconds) to actually die.

Chris

                 reply	other threads:[~2007-02-16 19:04 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=45D6001E.1020605@nortel.com \
    --to=cfriesen@nortel.com \
    --cc=linux-kernel@vger.kernel.org \
    --subject='Re: misleading comment in __oom_kill_task()?' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).