LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* misleading comment in __oom_kill_task()?
@ 2007-02-16 19:03 Chris Friesen
  0 siblings, 0 replies; only message in thread
From: Chris Friesen @ 2007-02-16 19:03 UTC (permalink / raw)
  To: linux-kernel


Towards the end of __oom_kill_task() we see the following comment/code:

	/*
	 * We give our sacrificial lamb high priority and access to
	 * all the memory it needs. That way it should be able to
	 * exit() and clear out its resources quickly...
	 */
	p->time_slice = HZ;
	set_tsk_thread_flag(p, TIF_MEMDIE);

	force_sig(SIGKILL, p);

I see it getting a large timeslice and access to memory, but I don't 
actually see the priority getting bumped at all.  It appears the comment 
is inaccurate.

Should the process actually get its priority bumped up as well so that 
it can process its own death faster?  The reason I ask is that we're 
seeing some oom-killed processes taking a very long time (multiple 
seconds) to actually die.

Chris

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2007-02-16 19:04 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2007-02-16 19:03 misleading comment in __oom_kill_task()? Chris Friesen

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).