LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Dan Aloni <da-x@monatomic.org>
To: Alan Stern <stern@rowland.harvard.edu>
Cc: Linux Kernel List <linux-kernel@vger.kernel.org>
Subject: Re: [linux-usb-devel] OOM and USB, latest Linux 2.6
Date: Sat, 17 Feb 2007 20:24:18 +0200	[thread overview]
Message-ID: <45D74852.4070206@monatomic.org> (raw)
In-Reply-To: <45D7462D.6080700@monatomic.org>

Dan Aloni wrote:
> Alan Stern wrote:
[...]
>> Can you be any more specific than that?  usb-storage should use only 
>> GFP_NOIO in its I/O paths.
>>
>>
>>   
> You are right, I looked over this state with kdb, and usb-storage
> waited in usb_stor_bulk_transfer_sg, which does pass GFP_NOIO
> at this scenario.
>
> It looked suspicious though, because OOM handling was invoked
> from many processes, and it didn't print about any process being
> killed and it didn't complain about no processes to kill either.
Hmm, I'm pretty sure I stomped over this (from select_bad_process()):

                /*
                 * This task already has access to memory reserves and is
                 * being killed. Don't allow any other task access to the
                 * memory reserve.
                 *
                 * Note: this may have a chance of deadlock if it gets
                 * blocked waiting for another task which itself is waiting
                 * for memory. Is there a better alternative?
                 */
                if (test_tsk_thread_flag(p, TIF_MEMDIE))
                        return ERR_PTR(-1UL);

Which might explains why the OOM handling was behaving like it did.

It would have been nice if it at least printed "OOM: I'm in a deadlock,
please FIXME...".

-- 
Dan Aloni
XIV LTD, http://www.xivstorage.com
da-x (at) monatomic.org, dan (at) xiv.co.il


  reply	other threads:[~2007-02-17 18:25 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-02-17 16:49 Dan Aloni
2007-02-17 16:57 ` [linux-usb-devel] " Alan Stern
2007-02-17 18:15   ` Dan Aloni
2007-02-17 18:24     ` Dan Aloni [this message]
2007-02-17 21:36     ` Alan Stern

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=45D74852.4070206@monatomic.org \
    --to=da-x@monatomic.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=stern@rowland.harvard.edu \
    --subject='Re: [linux-usb-devel] OOM and USB, latest Linux 2.6' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).