LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Petr Vandrovec <petr@vandrovec.name>
To: Pierre Ossman <drzeus-list@drzeus.cx>
Cc: LKML <linux-kernel@vger.kernel.org>
Subject: Re: NCPFS and brittle connections
Date: Mon, 19 Feb 2007 18:47:44 -0800	[thread overview]
Message-ID: <45DA6150.7060704@vandrovec.name> (raw)
In-Reply-To: <45D97DF0.9070306@drzeus.cx>

Pierre Ossman wrote:
> Sorry this took so long but I got occupied with other things and this
> had to move down the pile a bit.
> 
> New patch which uses dedicated buffers for the currently active packet.
> Also adds a new state RQ_ABANDONED which basically means "the caller no
> longer cares about this request so the pointers are no longer valid". It
> is used to determine if the global receive buffer should be copied to
> the provided one upon completion.

Hello,
   it would be nice if these two copies (request->txbuf, and 
rxbuf->reply) could be eliminated, but I see no easy way how to do that...

> commit 166fb223f9507431fb97820549e3e41980987445
> Author: Pierre Ossman <ossman@cendio.se>
> Date:   Mon Feb 19 11:34:43 2007 +0100
> 
>     ncpfs: make sure server connection survives a kill
>     
>     Use internal buffers instead of the ones supplied by the caller
>     so that a caller can be interrupted without having to abort the
>     entire ncp connection.
>     
>     Signed-off-by: Pierre Ossman <ossman@cendio.se>

Acked-by: Petr Vandrovec <petr@vandrovec.name>
(modulo one thing below)

> diff --git a/include/linux/ncp_fs_sb.h b/include/linux/ncp_fs_sb.h
> index a503052..d5e7ffc 100644
> --- a/include/linux/ncp_fs_sb.h
> +++ b/include/linux/ncp_fs_sb.h
> @@ -50,6 +50,8 @@ struct ncp_server {
>  	int packet_size;
>  	unsigned char *packet;	/* Here we prepare requests and
>  				   receive replies */
> +	unsigned char *txbuf;	/* Storage for current requres */

Looks like a typo?  requres => request ?

> +	unsigned char *rxbuf;	/* Storage for reply to current request */
>  
>  	int lock;		/* To prevent mismatch in protocols. */
>  	struct mutex mutex;

								Petr

  reply	other threads:[~2007-02-20  3:13 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-01-04 15:04 Pierre Ossman
2007-01-04 17:26 ` Petr Vandrovec
2007-01-04 19:30   ` Pierre Ossman
2007-01-05  7:43     ` Petr Vandrovec
2007-01-24 15:27       ` Pierre Ossman
2007-01-24 17:49         ` Petr Vandrovec
2007-01-24 22:01           ` Pierre Ossman
2007-01-25  8:22             ` Petr Vandrovec
2007-01-25 10:20               ` Pierre Ossman
2007-02-01  8:39                 ` Pierre Ossman
2007-02-04  6:00                 ` Petr Vandrovec
2007-02-04 17:17                   ` Pierre Ossman
2007-02-05  3:50                     ` Petr Vandrovec
2007-02-19 10:37                       ` Pierre Ossman
2007-02-20  2:47                         ` Petr Vandrovec [this message]
2007-02-20  6:37                           ` Pierre Ossman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=45DA6150.7060704@vandrovec.name \
    --to=petr@vandrovec.name \
    --cc=drzeus-list@drzeus.cx \
    --cc=linux-kernel@vger.kernel.org \
    --subject='Re: NCPFS and brittle connections' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).