LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Jeff Garzik <jeff@garzik.org>
To: Alan <alan@lxorguk.ukuu.org.uk>
Cc: Robert Hancock <hancockr@shaw.ca>,
	Tobias Diedrich <ranma+kernel@tdiedrich.de>,
	Linux Kernel ML <linux-kernel@vger.kernel.org>,
	linux-ide@vger.kernel.org
Subject: Re: pata_amd dropping to PIO on resume
Date: Tue, 20 Feb 2007 10:27:59 -0500	[thread overview]
Message-ID: <45DB137F.1060301@garzik.org> (raw)
In-Reply-To: <20070219220812.11c3baba@localhost.localdomain>

Alan wrote:
>> Deleting the ata_pci_clear_simplex() call, then adding 
>> ATA_FLAG_IGN_SIMPLEX to the ata_port_info info[] array, is also worth 
>> trying.
> 
> I think I know what is going on here. Firstly the simplex bits
> need re-clearing on a resume. On my todo list now I'm back

If the bit does not actually alter /hardware/ operation, then
ATA_FLAG_IGN_SIMPLEX use is preferred over having to remember various 
places where the bit must be twiddled.  Its easier to leave the bit in 
the BIOS-initialized state, and ignore the hardware bit's existence in 
software, if we know the behavior in the controller is hardwired.  Less 
room for software bugs that way, IMO.

	Jeff



  reply	other threads:[~2007-02-20 15:28 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <fa.q7ZuddHInqn2dVlS+EWjXjPvFC8@ifi.uio.no>
2007-02-16 23:18 ` Robert Hancock
2007-02-16 23:51   ` Jeff Garzik
2007-02-17  9:49     ` Tobias Diedrich
2007-02-19 22:08     ` Alan
2007-02-20 15:27       ` Jeff Garzik [this message]
2007-02-20 16:42         ` Alan
2007-02-16 16:21 Tobias Diedrich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=45DB137F.1060301@garzik.org \
    --to=jeff@garzik.org \
    --cc=alan@lxorguk.ukuu.org.uk \
    --cc=hancockr@shaw.ca \
    --cc=linux-ide@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=ranma+kernel@tdiedrich.de \
    --subject='Re: pata_amd dropping to PIO on resume' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).