LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* Re: [PATCH] pata_oldpiix: Call both PIO and DMA setup functions on switch as they are called on set up
2007-02-20 17:47 [PATCH] pata_oldpiix: Call both PIO and DMA setup functions on switch as they are called on set up Alan
@ 2007-02-20 16:53 ` Jeff Garzik
0 siblings, 0 replies; 2+ messages in thread
From: Jeff Garzik @ 2007-02-20 16:53 UTC (permalink / raw)
To: Alan; +Cc: akpm, linux-kernel
Alan wrote:
> Keeps the behaviour consistent and easier to understand.
>
> Signed-off-by: Alan Cox <alan@redhat.com>
>
> diff -u --new-file --recursive --exclude-from /usr/src/exclude linux.vanilla-2.6.20-mm2/drivers/ata/pata_oldpiix.c linux-2.6.20-mm2/drivers/ata/pata_oldpiix.c
> --- linux.vanilla-2.6.20-mm2/drivers/ata/pata_oldpiix.c 2007-02-20 13:37:58.000000000 +0000
> +++ linux-2.6.20-mm2/drivers/ata/pata_oldpiix.c 2007-02-20 13:54:49.000000000 +0000
> @@ -25,7 +25,7 @@
> #include <linux/ata.h>
>
> #define DRV_NAME "pata_oldpiix"
> -#define DRV_VERSION "0.5.3"
> +#define DRV_VERSION "0.5.4"
applied
^ permalink raw reply [flat|nested] 2+ messages in thread
* [PATCH] pata_oldpiix: Call both PIO and DMA setup functions on switch as they are called on set up
@ 2007-02-20 17:47 Alan
2007-02-20 16:53 ` Jeff Garzik
0 siblings, 1 reply; 2+ messages in thread
From: Alan @ 2007-02-20 17:47 UTC (permalink / raw)
To: jgarzik, akpm, linux-kernel
Keeps the behaviour consistent and easier to understand.
Signed-off-by: Alan Cox <alan@redhat.com>
diff -u --new-file --recursive --exclude-from /usr/src/exclude linux.vanilla-2.6.20-mm2/drivers/ata/pata_oldpiix.c linux-2.6.20-mm2/drivers/ata/pata_oldpiix.c
--- linux.vanilla-2.6.20-mm2/drivers/ata/pata_oldpiix.c 2007-02-20 13:37:58.000000000 +0000
+++ linux-2.6.20-mm2/drivers/ata/pata_oldpiix.c 2007-02-20 13:54:49.000000000 +0000
@@ -25,7 +25,7 @@
#include <linux/ata.h>
#define DRV_NAME "pata_oldpiix"
-#define DRV_VERSION "0.5.3"
+#define DRV_VERSION "0.5.4"
/**
* oldpiix_pre_reset - probe begin
@@ -209,10 +209,9 @@
struct ata_device *adev = qc->dev;
if (adev != ap->private_data) {
+ oldpiix_set_piomode(ap, adev);
if (adev->dma_mode)
oldpiix_set_dmamode(ap, adev);
- else if (adev->pio_mode)
- oldpiix_set_piomode(ap, adev);
}
return ata_qc_issue_prot(qc);
}
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2007-02-20 16:53 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2007-02-20 17:47 [PATCH] pata_oldpiix: Call both PIO and DMA setup functions on switch as they are called on set up Alan
2007-02-20 16:53 ` Jeff Garzik
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).