From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1030369AbXBTTqj (ORCPT ); Tue, 20 Feb 2007 14:46:39 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1030372AbXBTTqj (ORCPT ); Tue, 20 Feb 2007 14:46:39 -0500 Received: from mx1.redhat.com ([66.187.233.31]:34250 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1030369AbXBTTqi (ORCPT ); Tue, 20 Feb 2007 14:46:38 -0500 Message-ID: <45DB4C87.6050809@redhat.com> Date: Tue, 20 Feb 2007 14:31:19 -0500 From: Rik van Riel User-Agent: Thunderbird 1.5.0.7 (X11/20061004) MIME-Version: 1.0 To: Christoph Lameter CC: linux-kernel , linux-mm Subject: Re: [PATCH] free swap space when (re)activating page References: <45D63445.5070005@redhat.com> <45DAF794.2000209@redhat.com> <45DB25E1.7030504@redhat.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Christoph Lameter wrote: > On Tue, 20 Feb 2007, Rik van Riel wrote: > >> Nono, I try to remove the swap space occupied by pages that >> go back onto the active list. Regardless of whether they >> were already there, or whether they started out on the >> inactive list. > > Ok then do it for all pages that go back not just for those leftover from > the moving of pages to the inactive list (why would you move those???) I do. The only pages that are exempt are the pages that move from the active list to the inactive list, because those will probably be evicted soon enough. > Maybe the hunk does apply in a different location than I thought. I suspect that's the case ... > If you > do that in the loop over the pages on active list then it would make > sense. But in that case you need another piece of it doing the same to the > pages that are released at the end of shrink_active_list(). ... because I think this is what my patch does :) -- All Rights Reversed