LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH] devpts: add fsnotify create event
@ 2007-02-21  5:15 Florin Malita
  2007-02-27 19:16 ` H. Peter Anvin
  0 siblings, 1 reply; 2+ messages in thread
From: Florin Malita @ 2007-02-21  5:15 UTC (permalink / raw)
  To: akpm, hpa; +Cc: linux-kernel

Currently, devpts doesn't generate an fsnotify event upon pts creation 
because the regular vfs paths aren't involved. Deallocation, on the 
other hand, correctly generates a nameremove event thanks to the 
d_delete() invocation in devpts_pty_kill().

This patch adds the missing fsnotify_create() trigger in devpts_pty_new().

Signed-off-by: Florin Malita <fmalita@gmail.com>
---

 fs/devpts/inode.c |    5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/fs/devpts/inode.c b/fs/devpts/inode.c
index 643e57b..06ef9a2 100644
--- a/fs/devpts/inode.c
+++ b/fs/devpts/inode.c
@@ -19,6 +19,7 @@ #include <linux/mount.h>
 #include <linux/tty.h>
 #include <linux/devpts_fs.h>
 #include <linux/parser.h>
+#include <linux/fsnotify.h>
 
 #define DEVPTS_SUPER_MAGIC 0x1cd1
 
@@ -178,8 +179,10 @@ int devpts_pty_new(struct tty_struct *tt
 	inode->i_private = tty;
 
 	dentry = get_node(number);
-	if (!IS_ERR(dentry) && !dentry->d_inode)
+	if (!IS_ERR(dentry) && !dentry->d_inode) {
 		d_instantiate(dentry, inode);
+		fsnotify_create(devpts_root->d_inode, dentry);
+	}
 
 	mutex_unlock(&devpts_root->d_inode->i_mutex);
 



^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2007-02-27 19:17 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2007-02-21  5:15 [PATCH] devpts: add fsnotify create event Florin Malita
2007-02-27 19:16 ` H. Peter Anvin

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).