LKML Archive on
help / color / mirror / Atom feed
From: Robert Hancock <>
To: linux-kernel <>,, Jeff Garzik <>,
	Andrew Morton <>, Tejun Heo <>
Subject: [PATCH] sata_nv: complain on spurious completion notifiers
Date: Wed, 21 Feb 2007 23:53:03 -0600	[thread overview]
Message-ID: <> (raw)

Recently Tejun wrote a patch to ahci.c to make it raise a HSM violation
if the drive attempted to complete a tag that wasn't outstanding. We could
run into the same problem with sata_nv ADMA. This adds code to raise a HSM
violation error if the controller gives us a notifier tag that isn't
outstanding, since the drive may be issuing spurious completions.

Signed-off-by: Robert Hancock <>

--- linux-2.6.21-rc1edit/drivers/ata/sata_nv.c.prev	2007-02-21 22:17:31.000000000 -0600
+++ linux-2.6.21-rc1edit/drivers/ata/sata_nv.c	2007-02-21 22:22:14.000000000 -0600
@@ -740,6 +740,17 @@ static int nv_adma_check_cpb(struct ata_
 			DPRINTK("Completing qc from tag %d with err_mask %u\n",cpb_num,
+		} else {
+			struct ata_eh_info *ehi = &ap->eh_info;
+			/* Notifier bits set without a command may indicate the drive
+			   is misbehaving. Raise host state machine violation on this
+			   condition. */
+			ata_port_printk(ap, KERN_ERR, "notifier for tag %d with no command?\n",
+				cpb_num);
+			ehi->err_mask |= AC_ERR_HSM;
+			ehi->action |= ATA_EH_SOFTRESET;
+			ata_port_freeze(ap);
+			return 1;
 	return 0;

             reply	other threads:[~2007-02-22  5:54 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-02-22  5:53 Robert Hancock [this message]
2007-02-22  7:09 ` Tejun Heo
2007-02-23 10:37 ` Jeff Garzik

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \ \
    --subject='Re: [PATCH] sata_nv: complain on spurious completion notifiers' \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).