LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Simon Arlott <simon@arlott.org>
To: Duncan Sands <duncan.sands@math.u-psud.fr>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/2] usbatm: Increment module refcount when atm device is opened.
Date: Thu, 22 Feb 2007 19:50:02 +0000	[thread overview]
Message-ID: <45DDF3EA.3040407@simon.arlott.org.uk> (raw)
In-Reply-To: <200702221048.01623.duncan.sands@math.u-psud.fr>

[-- Attachment #1: Type: text/plain, Size: 1865 bytes --]

On 22/02/07 09:48, Duncan Sands wrote:
> What for?  Did you see any problems with the way it works right now?

It didn't make sense to be able to unload a module while it's actually in use, how does this work with automatic module loading/unloading (although I can't see how it's going to automatically load one of the sub drivers...)?


> How it works now is that if the module is unloaded while the device is
> in use, then the device is deregistered from the USB and ATM layers
> before the module unload completes.  Thus there should be no problem
> unloading the device at any moment.  
Ok.


> I'm guessing that you want this because of the better proc support you
> would like to add, which adds an extra callback into the module.

Actually it was partly because of the urb warning messages on unload... which the change doesn't even affect.


> This too should cause no problems as long as the appropriate tweaks are
> made to the shutdown code. I plan to make those adjustments, but I didn't
> find time yet - sorry.

I intend to export all the data via sysfs instead, since the current method of using proc (requiring several large enough read()s and no seeking) isn't very good and I can't see any way to improve it without caching the whole output from file open to close which atm doesn't support.

I was thinking that the MAC address/AAL stats should be removed from the proc output since they're already available from the atm devices proc file?


> PS: I plan to work on the drivers this weekend.

I don't expect to require any changes to usbatm to support sysfs, since the attributes should go with the usb device itself (and not the atm device). Perhaps there could be symlinks in each direction between the usb device and the atm device (like dvb/v4l do, e.g. atm:cxacru0 in the usb device)?

-- 
Simon Arlott


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 829 bytes --]

      reply	other threads:[~2007-02-22 19:51 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-02-21 21:36 Simon Arlott
2007-02-22  9:48 ` Duncan Sands
2007-02-22 19:50   ` Simon Arlott [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=45DDF3EA.3040407@simon.arlott.org.uk \
    --to=simon@arlott.org \
    --cc=9b8ea2f16ca756b7641hkjxy0006dn1i@thunder.lp0.eu \
    --cc=duncan.sands@math.u-psud.fr \
    --cc=linux-kernel@vger.kernel.org \
    --subject='Re: [PATCH 1/2] usbatm: Increment module refcount when atm device is opened.' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).