LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Michael Tokarev <mjt@tls.msk.ru>
To: Jan Engelhardt <jengelh@linux01.gwdg.de>
Cc: dsaxena@plexity.net, linux-kernel@vger.kernel.org
Subject: Re: Modprobe as script breaks initramfs kernel?
Date: Thu, 22 Feb 2007 23:52:16 +0300	[thread overview]
Message-ID: <45DE0280.9070700@tls.msk.ru> (raw)
In-Reply-To: <Pine.LNX.4.61.0702221941290.7553@yvahk01.tjqt.qr>

Jan Engelhardt wrote:
> On Feb 22 2007 14:30, Michael Tokarev wrote:
>> Deepak Saxena wrote:
>>> We attempted an experiment in cleaning up some modprobe messages during 
>>> initramfs bootup when the modules directory is missing by moving modprobe 
>>> to modprobe-bin and replacing modprobe with the following simple shell script:
>>>
>>> #!/bin/sh
>>> # Clean up bootup when modules are not present
>>>
>>> if [ -e "/lib/modules/'uname -r'/modules.dep" ] ; then
>>> 	/sbin/modprobe-bin $*
> 
> The nitpick guide says: `uname -r` and "$@" instead of $*  ;-)

Here, it's possible to workaround the pipefs issue... with another kernel
bugfix.  uname -r is available in /proc/sys/kernel/version, but the problem
is that reading almost any file in /proc with shell, which does read by a
single byte, returns only first byte of of the file being read.  The bug
has been addressed by Andrew recently, but I don't remember if the fix is
in 2.6.20 or 2.6.19.x yet.  I discovered it exactly because of this very
issue - hit pipefs bug and tried to work around it by replacing the above
construct with

   read version < /proc/sys/kernel/version
   ... /lib/modules/$version/modules.dep ...

wich results in $version being set to.. "2" (from "2.6...." :)

But sure, the usage is wrong, albiet ok for some minimal debugging.

>>> BUG: unable to handle kernel NULL pointer dereference at virtual address 00000014
>>> Trace; c0107737 <sys_pipe+17/60>

>> This is the same issue I reported much earlier with /sbin/hotplug being a script
>> in initrfamfs.  The problem is because pipefs isn't initialized yet at the time
>> the script gets called, and causes a NULL-pointer deref.  Obviously you're using
>> pipe above.
> 
> Btw, has this pipefs issue been adressed (by moving pipefs before initramfs
> stage), or something?

Not as I know of.  It has been discussed, but seems to be of low priority.

At least, reading /proc file is fixed... somewhere... :)  So it's now possible
to work around it, at least in some places (because sometimes pipe is really
useful anyway and difficult to substitute with something ;)

/mjt

  reply	other threads:[~2007-02-22 20:52 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-02-22  0:33 Deepak Saxena
2007-02-22 11:30 ` Michael Tokarev
2007-02-22 18:44   ` Jan Engelhardt
2007-02-22 20:52     ` Michael Tokarev [this message]
2007-02-23  3:44     ` Deepak Saxena

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=45DE0280.9070700@tls.msk.ru \
    --to=mjt@tls.msk.ru \
    --cc=dsaxena@plexity.net \
    --cc=jengelh@linux01.gwdg.de \
    --cc=linux-kernel@vger.kernel.org \
    --subject='Re: Modprobe as script breaks initramfs kernel?' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).