LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Rik van Riel <riel@redhat.com>
To: 7eggert@gmx.de
Cc: Christoph Lameter <clameter@sgi.com>,
	linux-kernel <linux-kernel@vger.kernel.org>,
	linux-mm <linux-mm@kvack.org>, Andrew Morton <akpm@osdl.org>
Subject: Re: [PATCH] free swap space when (re)activating page
Date: Thu, 22 Feb 2007 22:34:25 -0500	[thread overview]
Message-ID: <45DE60C1.2020103@redhat.com> (raw)
In-Reply-To: <E1HKPTs-0005p5-IV@be1.lrz>

Bodo Eggert wrote:
> Rik van Riel <riel@redhat.com> wrote:
> 
> +++ linux-2.6.20.noarch/mm/swap.c        2007-02-20 06:44:17.000000000 -0500
> @@ -420,6 +420,26 @@ void pagevec_strip(struct pagevec *pvec)
> 
>> +                        if (printk_ratelimit())
>> +                                printk("kswapd freed a swap space\n");
>>
> 
> NOOOOOOOOOOOOOOOOOOOOOOOOOOOOOO!!!!!!!!!!!
> 
> 1) This message is a debug message! You forgot to set the printk level.

Doh, I forgot to cut it out of the patch when I fixed it
according to Christoph's hint.

This chunk should be removed from the patch...

Andrew, I'll send you a new one tomorrow morning.

-- 
Politics is the struggle between those who want to make their country
the best in the world, and those who believe it already is.  Each group
calls the other unpatriotic.

  reply	other threads:[~2007-02-23  3:34 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <7Pk3X-bD-17@gated-at.bofh.it>
     [not found] ` <7QvgM-3aK-3@gated-at.bofh.it>
     [not found]   ` <7QDeB-7KY-11@gated-at.bofh.it>
     [not found]     ` <7QGc7-3ZB-13@gated-at.bofh.it>
     [not found]       ` <7QGlP-4e1-11@gated-at.bofh.it>
     [not found]         ` <7QHUO-6RS-5@gated-at.bofh.it>
     [not found]           ` <7QJ9Y-mo-1@gated-at.bofh.it>
     [not found]             ` <7QJk7-zW-51@gated-at.bofh.it>
2007-02-23  1:44               ` [PATCH] free swap space when (re)activating page Bodo Eggert
2007-02-23  3:34                 ` Rik van Riel [this message]
2007-02-21 15:09 Al Boldi
  -- strict thread matches above, loose matches on Subject: below --
2007-02-16 22:46 Rik van Riel
2007-02-20  4:53 ` Christoph Lameter
2007-02-20 13:28   ` Rik van Riel
2007-02-20 16:37     ` Christoph Lameter
2007-02-20 16:46       ` Rik van Riel
2007-02-20 18:20         ` Christoph Lameter
2007-02-20 19:31           ` Rik van Riel
2007-02-20 19:42             ` Christoph Lameter
2007-02-20 19:54             ` Rik van Riel
2007-02-20 20:26               ` Christoph Lameter
2007-02-20 20:57               ` Christoph Lameter
2007-02-20 19:00 ` William Lee Irwin III

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=45DE60C1.2020103@redhat.com \
    --to=riel@redhat.com \
    --cc=7eggert@gmx.de \
    --cc=akpm@osdl.org \
    --cc=clameter@sgi.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).