LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Tejun Heo <htejun@gmail.com>
To: Adrian Bunk <bunk@stusta.de>
Cc: "Rafael J. Wysocki" <rjw@sisk.pl>,
	linux-ide@vger.kernel.org, Andrew Morton <akpm@osdl.org>,
	Jeff Garzik <jeff@garzik.org>, Alan <alan@lxorguk.ukuu.org.uk>,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: 2.6.20-git10 (and -git13): BUG at drivers/pci/pci.c:817 during resume from disk
Date: Mon, 26 Feb 2007 01:37:08 +0900	[thread overview]
Message-ID: <45E1BB34.6010608@gmail.com> (raw)
In-Reply-To: <20070225163200.GZ12392@stusta.de>

Adrian Bunk wrote:
> On Sun, Feb 25, 2007 at 01:28:42PM +0900, Tejun Heo wrote:
>> Hello, Adrian.
>>
>> Adrian Bunk wrote:
>>> On Tue, Feb 20, 2007 at 12:43:41PM +0900, Tejun Heo wrote:
>>>> Rafael J. Wysocki wrote:
>>>>> Update:
>>>>>
>>>>> I get the same BUG with 2.6.20-git13 100% of the time during the resume.
>>>>> The system seems to be fully functional nonetheless.
>>>> Known bug, will be fixed soon.
>>> Is this a variation of
>>>
>>> Subject    : HP nx6325: usb mouse stops working after resume from ram
>>> References : http://lkml.org/lkml/2007/2/21/413
>>> Submitter  : Arkadiusz Miskiewicz <arekm@maven.pl>
>>> Caused-By  : Konstantin Karasyov <konstantin.a.karasyov@intel.com>
>>>              commit 0a6139027f3986162233adc17285151e78b39cac
>>> Status     : unknown
>>>
>>> or one of the other ACPI problems in 2.6.21-rc1?
>> No, it's not related to ACPI.  It's caused by devres changes and fixed
>> in libata-dev tree.
> 
> I'm currently a bit lost with all the ATA/ACPI/suspend regression 
> reports...
> 
> Which patch fixes this regression?

What I was talking about was the following one.  It's a libata bug
discovered by devres sanity check and unrelated to ACPI.

Author: Tejun Heo <htejun@gmail.com>  2007-02-20 18:14:48
Committer: Jeff Garzik <jeff@garzik.org>  2007-02-21 18:58:18
Parent: 5e5c74a5e11d1e2a99d03132cc6c4455016db6c2 (sata_nv: delay on switching between NCQ and non-NCQ commands)
Child:  6d1245bf294e9ea65b3717be9fa0338bfb6ff6c9 (libata: separate out ata_ncq_enabled())
Branches: upstream-fixes, upstream, ALL
Follows: v2.6.21-rc1
Precedes: 

    libata: disable pdev on all suspend events
    
    libata used disable pdev only on PM_EVENT_SUSPEND while re-enable pdev
    unconditionally.  This was okay before ref-counted pdev enable update
    but it now makes the pdev pinned after swsusp cycle (enabled twice but
    disabled only once) and devres sanity check whines about it.
    
    Fix it by unconditionally disabling pdev on all suspend events.
    
    Signed-off-by: Tejun Heo <htejun@gmail.com>
    Signed-off-by: Jeff Garzik <jeff@garzik.org>

-- 
tejun

      reply	other threads:[~2007-02-25 16:37 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-02-14 23:16 2.6.20-git10: BUG at drivers/pci/pci.c:817 during suspend to disk Rafael J. Wysocki
2007-02-15 11:23 ` Rafael J. Wysocki
2007-02-17 10:00   ` 2.6.20-git10 (and -git13): BUG at drivers/pci/pci.c:817 during resume from disk Rafael J. Wysocki
2007-02-20  3:43     ` Tejun Heo
2007-02-24 23:02       ` Adrian Bunk
2007-02-25  4:28         ` Tejun Heo
2007-02-25 16:32           ` Adrian Bunk
2007-02-25 16:37             ` Tejun Heo [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=45E1BB34.6010608@gmail.com \
    --to=htejun@gmail.com \
    --cc=akpm@osdl.org \
    --cc=alan@lxorguk.ukuu.org.uk \
    --cc=bunk@stusta.de \
    --cc=jeff@garzik.org \
    --cc=linux-ide@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rjw@sisk.pl \
    --subject='Re: 2.6.20-git10 (and -git13): BUG at drivers/pci/pci.c:817 during resume from disk' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).