LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Patrick McHardy <kaber@trash.net>
To: Martin Josefsson <gandalf@wlug.westbo.se>
Cc: Chuck Ebbert <cebbert@redhat.com>,
netfilter-devel@lists.netfilter.org,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: Soft lockup on shutdown in nf_ct_iterate_cleanup()
Date: Sun, 25 Feb 2007 20:03:36 +0100 [thread overview]
Message-ID: <45E1DD88.6080206@trash.net> (raw)
In-Reply-To: <1172428694.4485.31.camel@localhost.localdomain>
Martin Josefsson wrote:
> What about this case:
>
> 1. Conntrack entry is created and placed on the unconfirmed list
> 2. The event cache bumps the refcount of the conntrack entry
> 3. module removal of ip_conntrack unregisters all hooks
> 4. packet is dropped by an iptables rule
> 5. packet is freed but we still have a refcount on the conntrack entry
>
> Now there's no way to get that refcount to decrease as that only happens
> when the event cache receives another packet or the current packet makes
> it through the stack as you wrote above. And neither of this will happen
> since we unregistered the hooks providing the packets and dropped the
> packet.
The event cache is flushed on conntrack module unload after the hooks
have been unregistered, which should release all references.
next prev parent reply other threads:[~2007-02-25 19:03 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-02-21 1:10 Chuck Ebbert
2007-02-22 0:56 ` Chuck Ebbert
2007-02-24 13:58 ` Patrick McHardy
2007-02-24 16:18 ` Chuck Ebbert
2007-02-25 17:31 ` Patrick McHardy
2007-02-25 18:38 ` Martin Josefsson
2007-02-25 19:03 ` Patrick McHardy [this message]
2007-02-26 17:14 ` Chuck Ebbert
2007-02-26 17:53 ` Patrick McHardy
2007-02-26 21:21 ` Chuck Ebbert
2007-02-28 18:09 ` Patrick McHardy
2007-02-28 20:30 ` Chuck Ebbert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45E1DD88.6080206@trash.net \
--to=kaber@trash.net \
--cc=cebbert@redhat.com \
--cc=gandalf@wlug.westbo.se \
--cc=linux-kernel@vger.kernel.org \
--cc=netfilter-devel@lists.netfilter.org \
--subject='Re: Soft lockup on shutdown in nf_ct_iterate_cleanup()' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).